keys-rename

Author: soullivaneuh

src/DependencyInjection/Configuration.php

@@ -664,7 +664,7 @@ private function createAuthenticationPluginNode(): NodeDefinition
 
                                 break;
                             case 'header':
-                                $this->validateAuthenticationType(['key', 'value'], $config, 'header');
+                                $this->validateAuthenticationType(['header_name', 'header_value'], $config, 'header');
 
                                 break;
                         }
@@ -682,8 +682,8 @@ private function createAuthenticationPluginNode(): NodeDefinition
                     ->scalarNode('password')->end()
                     ->scalarNode('token')->end()
                     ->scalarNode('service')->end()
-                    ->scalarNode('key')->end()
-                    ->scalarNode('value')->end()
+                    ->scalarNode('header_name')->end()
+                    ->scalarNode('header_value')->end()
                     ->arrayNode('params')->prototype('scalar')->end()
                     ->end()
                 ->end()

src/DependencyInjection/HttplugExtension.php

@@ -384,8 +384,8 @@ private function configureAuthentication(ContainerBuilder $container, array $con
                     break;
                 case 'header':
                     $container->register($authServiceKey, Header::class)
-                        ->addArgument($values['key'])
-                        ->addArgument($values['value']);
+                        ->addArgument($values['header_name'])
+                        ->addArgument($values['header_value']);
 
                     break;
                 case 'service':

tests/Resources/Fixtures/config/full.php

@@ -98,8 +98,8 @@
             ],
             'my_header' => [
                 'type' => 'header',
-                'key' => 'foo',
-                'value' => 'bar',
+                'header_name' => 'foo',
+                'header_value' => 'bar',
             ],
             'my_service' => [
                 'type' => 'service',

tests/Resources/Fixtures/config/full.xml

@@ -58,7 +58,7 @@
                 <my_basic type="basic" username="foo" password="bar"/>
                 <my_wsse type="wsse" username="foo" password="bar"/>
                 <my_bearer type="bearer" token="foo"/>
-                <my_header type="header" key="foo" value="bar" />
+                <my_header type="header" header_name="foo" header_value="bar" />
                 <my_service type="service" service="my_auth_service"/>
             </authentication>
             <cache cache-pool="my_cache_pool" stream-factory="my_other_stream_factory">

tests/Resources/Fixtures/config/full.yml

@@ -67,8 +67,8 @@ httplug:
                 token: foo
             my_header:
                 type: header
-                key: foo
-                value: bar
+                header_name: foo
+                header_value: bar
             my_service:
                 type: service
                 service: my_auth_service

tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -246,8 +246,8 @@ public function testSupportsAllConfigFormats(): void
                     ],
                     'my_header' => [
                         'type' => 'header',
-                        'key' => 'foo',
-                        'value' => 'bar',
+                        'header_name' => 'foo',
+                        'header_value' => 'bar',
                         'params' => [],
                     ],
                     'my_service' => [