Update CacheDataCollector.php #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change private method getCasters to protected
Nyholm
reviewed
Aug 8, 2017
| * @return callable[] The casters to add to the cloner | ||
| */ | ||
| private function getCasters() | ||
| protected function getCasters() |
Member
There was a problem hiding this comment.
This will override any changes Symfony is making to this file. That might lead to issues when you are using SF 3.2 or higher.
To be compatible with both 2.8, 3.1, 3.2, 3.3 we should rename this function to any thing else.
I copied this method from sf 3.3 that is why it has the same name
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=========================================
Coverage 35.44% 35.44%
Complexity 205 205
=========================================
Files 21 21
Lines 869 869
=========================================
Hits 308 308
Misses 561 561
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change private method getCasters to protected