From f747789d935ef648cd8316b8717672baf58f054d Mon Sep 17 00:00:00 2001 From: Ryan Weaver Date: Thu, 9 Nov 2017 15:30:24 -0500 Subject: [PATCH 1/2] Adding tests for Symfony 4 BETA --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 7dfd662c..f9bf5a3c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -32,6 +32,8 @@ matrix: env: SYMFONY_VERSION=2.8.* - php: 7.0 env: SYMFONY_VERSION=3.0.* + - php: 7.1 + env: DEPENDENCIES=beta allow_failures: - php: nightly @@ -42,6 +44,7 @@ env: before_install: - phpenv config-rm xdebug.ini || echo "xdebug not available"; + - if [ "$DEPENDENCIES" = "beta" ]; then perl -pi -e 's/^}$/,"minimum-stability":"beta"}/' composer.json; fi; - if [ "$SYMFONY_VERSION" != "" ]; then composer require --no-update symfony/framework-bundle "$SYMFONY_VERSION"; fi - if [ "$COMPOSER_FLAGS" != "" ]; then composer update --prefer-dist --no-interaction --no-scripts $COMPOSER_FLAGS; fi; From eca24996e491073945d330d72765b019e2f308bc Mon Sep 17 00:00:00 2001 From: Ryan Weaver Date: Thu, 9 Nov 2017 15:52:46 -0500 Subject: [PATCH 2/2] Fixing a bug The $callbacks are eventually passed to addDequeuerAwareCall, which expects a string, not a Reference object. In Symfony 3, the Reference was cast to a string, which returned the id, so it worked. --- DependencyInjection/OldSoundRabbitMqExtension.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DependencyInjection/OldSoundRabbitMqExtension.php b/DependencyInjection/OldSoundRabbitMqExtension.php index e7fe4bfe..86f8e4d7 100644 --- a/DependencyInjection/OldSoundRabbitMqExtension.php +++ b/DependencyInjection/OldSoundRabbitMqExtension.php @@ -255,7 +255,7 @@ protected function loadMultipleConsumers() foreach ($consumer['queues'] as $queueName => $queueOptions) { $queues[$queueOptions['name']] = $queueOptions; $queues[$queueOptions['name']]['callback'] = array(new Reference($queueOptions['callback']), 'execute'); - $callbacks[] = new Reference($queueOptions['callback']); + $callbacks[] = $queueOptions['callback']; } $definition = new Definition('%old_sound_rabbit_mq.multi_consumer.class%');