Fetch::fetchStarterKit() attempts to delete /tmp on clean-up #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmolsen
added a commit
that referenced
this pull request
Nov 24, 2015
Fetch::fetchStarterKit() attempts to delete /tmp on clean-up
Member
|
Thanks :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a couple issues trying to testout the new version of patternlab. If pulls are welcome, I'm happy to help where I can.
This defect could be important as it would delete a users system /tmp directory under certain circumstances.
The offending code is
$tempDir = sys_get_temp_dir();. To resolve the issue, a sub-directory in system temp is created.