Skip to content

fix(package): remove jshint #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018
Merged

fix(package): remove jshint #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/uikit-workshop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
"license": "MIT",
"repository": "https://github.com/pattern-lab/patternlab-node/tree/master/packages/uikit-workshop",
"bugs": "https://github.com/pattern-lab/patternlab-node/issues",
"peerDependencies": {
"jshint": "^2.9.5"
},
"devDependencies": {
"node-sass-selector-importer": "^5.2.0",
"@babel/core": "^7.0.0",
Expand All @@ -51,7 +48,6 @@
"css-loader": "^1.0.0",
"html-loader": "^0.5.5",
"html-webpack-plugin": "github:jantimon/html-webpack-plugin#webpack-4",
"jshint": "^2.9.6",
"mini-css-extract-plugin": "^0.4.1",
"no-emit-webpack-plugin": "^1.0.0",
"node-sass": "^4.9.3",
Expand Down Expand Up @@ -93,15 +89,13 @@
"iframe-resizer": "^3.6.2",
"jquery": "^3.3.1",
"js-cookie": "^2.2.0",
"jshint": "^2.9.5",
"mousetrap": "^1.6.2",
"preact-compat": "^3.18.4",
"preact": "^8.3.1",
"prism": "^4.1.2",
"prismjs": "^1.15.0",
"pwa-helpers": "^0.8.3",
"redux-thunk": "^2.3.0",
Copy link
Contributor

@sghoweri sghoweri Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that we’ll need this react-animate-height package once #960 hits so we’ll need to be adding this right back in... thoughts?

Copy link
Member Author

@bmuenzenmeyer bmuenzenmeyer Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at first this was super odd to me that it was removed, because I did not recall doing it (it was late though 🕦)

this package is already in the same list: here and I suspect npm removed it automatically.

I've seen some tools that alphabetize dependencies. but 🤷‍♂️ 🕵️

"react-animate-height": "^2.0.4",
"redux": "^4.0.0",
"reselect": "^3.0.1",
"scriptjs": "^2.5.8",
Expand Down