fix(package): remove jshint #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sghoweri
reviewed
Oct 31, 2018
| "prism": "^4.1.2", | ||
| "prismjs": "^1.15.0", | ||
| "pwa-helpers": "^0.8.3", | ||
| "redux-thunk": "^2.3.0", |
Contributor
There was a problem hiding this comment.
Keep in mind that we’ll need this react-animate-height package once #960 hits so we’ll need to be adding this right back in... thoughts?
Member
Author
There was a problem hiding this comment.
at first this was super odd to me that it was removed, because I did not recall doing it (it was late though 🕦)
this package is already in the same list: here and I suspect npm removed it automatically.
I've seen some tools that alphabetize dependencies. but 🤷♂️ 🕵️
sghoweri
approved these changes
Oct 31, 2018
Contributor
sghoweri
left a comment
sghoweri
left a comment
There was a problem hiding this comment.
See my comment about the react-animate-height library (not a blocker though) — other than that this looks good to go. Thanks!
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
fix(package): remove jshint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #964
Summary of changes:
cc @c1rrus