Skip to content

Conversation

@bmuenzenmeyer
Copy link
Member

Addresses #133

Summary of changes:

  • moved builder/*.js files and fixed all references
  • move source/_patternlab-files/partials to core/templates
  • move source/_patternlab-files/pattern-header-footer to core/source/_meta
  • move source/eveythingelseish to core/source ?????
  • "Open in new window" should be a page with no PL JS #265 moving off this PR
  • meta patterns missing? #169
  • testing
  • add support for {{ cacheBuster }}
  • as of writing, passing unit tests and building frontend

passing unit tests and building frontend

#133
@bmuenzenmeyer bmuenzenmeyer self-assigned this Mar 2, 2016
@bmuenzenmeyer bmuenzenmeyer added this to the v1.2.0 milestone Mar 2, 2016
move source/_patternlab-files/pattern-header-footer to core/source/_meta
updated config entries

#133
@geoffp
Copy link
Contributor

geoffp commented Mar 2, 2016

YES

@bmuenzenmeyer
Copy link
Member Author

I was initially going to put the shipped patterns into core/source and then build a mechanism to move them over into config.source.* path, but I don't really see a big benefit aside from having a clean copy if a user wanted it. Need to think about it more. Thinking through to the eventual inclusion of starter kits, seems easier to deviate from this PHP pattern

add user defined atoms-_head and atoms-_foot pattern
move patterns to account for new dir
move footer and header to proper place
inject header and footer into styleguide, index, and pattern html
bmuenzenmeyer pushed a commit that referenced this pull request Mar 7, 2016
Restructure filesystem to better align concerns and support upgrades
@bmuenzenmeyer bmuenzenmeyer merged commit a8f83ce into dev Mar 7, 2016
@bmuenzenmeyer bmuenzenmeyer deleted the 133 branch March 7, 2016 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants