bugfix: #171 pattern links inside base data object #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minor refactor allows for pattern links insde `_data.json` as well as pattern `*.json` objects Also notice the RegExp has been updated to only match `link\.[A-z0-9-_]` to avoid matching `link123something` or `link*something`
Member
|
Hey @kylewelsby I intend to look closer at this sometime this week or this weekend. |
Contributor
Author
|
thanks, no problem |
Contributor
Author
|
I have just pushed another bugfix to this issue, it basically enables pseudo-patterns to be linked to within data. |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Feb 7, 2016
bugfix: #171 pattern links inside base data object
bmuenzenmeyer
added a commit
that referenced
this pull request
Feb 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I would like to submit a minor bugfix to v1.0.0 regarding Added ability to specify link. urls inside data objects*
This minor refactor allows for pattern links insde
_data.jsonas well as pattern*.jsonobjectsAlso notice the RegExp has been updated to only match
link\.[A-z0-9-_]to avoid matchinglink123somethingorlink*somethingChanged: target to dev branch