refactor: fixed scrolling to annotations #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctionality we've been using a JS plugin previously most likely to enable or polyfill the smooth scrolling behaviour.
JosefBredereck
approved these changes
Jan 31, 2022
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* refactor: fixed scrolling behaviour and replaced plugin by native functionality we've been using a JS plugin previously most likely to enable or polyfill the smooth scrolling behaviour. * refactor: removed the plugin / dependency * chore: test for that method first of all * chore: code reformatting * Revert "chore: code reformatting" This reverts commit 0f7f4f3. * Revert "chore: test for that method first of all" This reverts commit 795546f. * Revert "refactor: removed the plugin / dependency" This reverts commit a3522d1. * Revert "refactor: fixed scrolling behaviour and replaced plugin by native functionality" This reverts commit cb2102c. * fix: removed the incorrect attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1416 and #1408
The refactoring with 70fe9b6 within the file
modal-viewer.jsfor #960 and #973 lead to this functionality breaking, as the parameters of the JavaScript plugin being used most likely to enable the smooth scrolling were used incorrectly.Summary of changes:
Removed the incorrect attribute.