uikit-workshop 5.5.0 crashes during `serve` when adding an empty pattern file

[ringods]

I am using Pattern Lab Node v5.5.0 on Mac, with Node v13.5.0, using a Custom Edition.

Expected Behavior

patternlab serve should rebuild and reload correctly when I add a new empty pattern in any of the pattern folders.

Actual Behavior

When I add an empty pattern file in any of the pattern folders, the patterns are rebuilt but then patternlab serve crashes on me:

...
Built pattern: templates-home
Built pattern: pages-home
Built pattern: pages-welcome
Omitting pages-welcome from styleguide patterns because it is defined as a defaultPattern.
Built Pattern Lab front end
Assertion failed: (0), function uv_close, file ../deps/uv/src/unix/core.c, line 187.
[1]    90622 abort      npm run pl:serve
Time: 0h:00m:42s

Steps to Reproduce

Use @patternlab/uikit-workshop v5.5.0 in devDependencies of my setup. When I revert to v5.4.0, the error is gone.

[sghoweri]

Thanks for submitting this @ringods!

We'll need to do some digging however my initial suspicion is that this might have something to do with Node v13 (vs Node v12). 🤔

[ringods]

@sghoweri In the meantime, I switched to Node v12 too and the problems are gone. So you suspicion makes sense. ;-)

[maxleistner]

Hi there. I am on node v12.3.6 and the error pops up again.
(Pattern Lab Node Core version: 5.10.1)

Any suggestions?

[jeffwhitfield]

Happening for me too. Just randomly happens without any rhyme or reason...even after just a simple edit to an HBS file. Very annoying since it constantly interrupts my workflow. :(

Built pattern: pages-collection
Built pattern: pages-product
Omitting atoms-colors from styleguide patterns because it has an underscore prefix.
Built Pattern Lab front end
Assertion failed: (0), function uv_close, file ../deps/uv/src/unix/core.c, line 174.
[1]    57247 abort      npm run serve

Running on Node 14.12.0 with the following Pattern Lab dependencies:

    "@pattern-lab/cli": "^5.13.1",
    "@pattern-lab/core": "^5.13.1",
    "@pattern-lab/engine-handlebars": "^5.10.1",
    "@pattern-lab/starterkit-handlebars-demo": "^5.11.1",
    "@pattern-lab/uikit-workshop": "^5.13.1",
    "create-pattern-lab": "^5.13.1",

Being that it happens on other versions of Node makes it rather unlikely it's just a simple Node issue. :P

[sdlambert]

Assertion failed: (0), function uv_close, file ../deps/uv/src/unix/core.c, line 174.

I am getting this error on Node v 12.16.3 with the latest Pattern Lab, as well. The issue persists even when rolling back to 5.13.1 as suggested above. This is on a fresh install.

[JosefBredereck]

@jeffwhitfield @sdlambert, can one of you tell me what exactly you did and which operating system you use?

I tested this with a fresh installation and added, deleted, and even renamed empty patterns or any other pattern.
Are you using npm or yarn?

[jeffwhitfield]

@joekarasek I'm currently on macOS Big Sur v11.1 using Node v12.2. Here's what's in my package.json file if that helps any:

{
  "name": "hcp-design-system",
  "version": "1.0.0",
  "description": "HCP app design system and component library",
  "main": "index.js",
  "scripts": {
    "pl:build": "patternlab build --config ./patternlab-config.json",
    "pl:help": "patternlab --help",
    "pl:install": "patternlab install --config ./patternlab-config.json",
    "pl:serve": "patternlab serve --config ./patternlab-config.json",
    "pl:version": "patternlab --version",
    "build": "patternlab build --config ./patternlab-config.json",
    "serve": "patternlab serve --config ./patternlab-config.json",
    "dev": "npm run development",
    "development": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch": "npm run development -- --watch",
    "hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
    "prod": "npm run production",
    "production": "cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --no-progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
  },
  "author": "Jeff Whitfield",
  "license": "ISC",
  "devDependencies": {
    "@pattern-lab/cli": "^5.13.2",
    "@pattern-lab/core": "^5.13.2",
    "@pattern-lab/engine-handlebars": "^5.10.1",
    "@pattern-lab/starterkit-handlebars-vanilla": "^1.4.0",
    "@pattern-lab/uikit-workshop": "^5.13.2",
    "create-pattern-lab": "^5.13.2",
    "cross-env": "^7.0.3",
    "laravel-mix": "^5.0.9",
    "sass": "^1.30.0",
    "sass-loader": "^8.0.2",
    "tailwindcss": "npm:@tailwindcss/postcss7-compat@^2.0.1",
    "vue-template-compiler": "^2.6.12"
  },
  "dependencies": {}
}

[jeffwhitfield]

Yeah, it's virtually unusable now due to all the uv_close crashes. There's a mention of this error here:

webpack/webpack#10037

Might be due to issues with Webpack. As it stands though, I'll likely need to just stop using Pattern Lab till it's fixed. :(

[StfBauer]

Happens from time to time in my setup as well:

{
  "name": "liquid-core",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "pl:build": "patternlab build --config ./patternlab-config.json",
    "pl:publish": "patternlab build --config ./patternlab-public.json",
    "pl:help": "patternlab --help",
    "pl:install": "patternlab install --config ./patternlab-config.json",
    "pl:serve": "patternlab serve --config ./patternlab-config.json",
    "gulp:serve": "gulp",
    "gulp:serveStyles2": "gulp serveStyles2",
    "pl:version": "patternlab --version"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@pattern-lab/cli": "^5.14.1",
    "@pattern-lab/core": "^5.14.1",
    "@pattern-lab/engine-handlebars": "^5.14.0",
    "@pattern-lab/uikit-workshop": "^5.14.1",
    "postcss": "^8.2.6"
  },
  "devDependencies": {
    "gulp": "^4.0.2",
    "gulp-autoprefixer": "^7.0.1",
    "gulp-load-plugins": "^2.0.6",
    "gulp-plumber": "^1.2.1",
    "gulp-postcss": "^9.0.0",
    "gulp-sass": "^4.1.0",
    "gulp-sourcemaps": "^3.0.0",
    "node-sass": "^5.0.0",
    "npm-run-all": "^4.1.5"
  }
}

Tested NodeJS versions: 12, 14
NodeJS 13 is the only one that seems to work properly.

• NodeJS ATM: v12.21.0
• NPM version: 6.14.11