Fix the resource lookup for starterkits

Author: ringods

package.json

@@ -41,7 +41,7 @@
     "publish": "npx lerna publish -m \"[skip travis] chore(release): publish %s\"",
     "postpublish": "auto release",
     "preview:docs": "cd packages/docs && yarn production",
-    "preview:hbs": "cd packages/development-edition-engine-handlebars && npx patternlab add --starterkits @pattern-lab/starterkit-handlebars-vanilla && npm run pl:build"
+    "preview:hbs": "cd packages/development-edition-engine-handlebars && yarn pl:starterkit && yarn pl:build"
   },
   "nyc": {
     "exclude": [

packages/cli/bin/install-starterkit.js

@@ -8,7 +8,7 @@ const {
   readJsonAsync,
 } = require('./utils');
 const {
-  resolveFileInPackage,
+  resolvePackageFolder,
   resolveDirInPackage,
 } = require('@pattern-lab/core/src/lib/resolver');
 
@@ -19,7 +19,10 @@ const installStarterkit = (starterkit, config) =>
     yield checkAndInstallPackage(name);
     yield copyAsync(resolveDirInPackage(name, 'dist'), path.resolve(sourceDir));
     let kitConfig;
-    const kitConfigPath = resolveFileInPackage(name, 'patternlab-config.json');
+    const kitConfigPath = path.join(
+      resolvePackageFolder(name),
+      'patternlab-config.json'
+    );
     if (fs.existsSync(kitConfigPath)) {
       kitConfig = yield readJsonAsync(kitConfigPath);
     }

packages/core/src/lib/resolver.js

@@ -10,14 +10,6 @@ const resolveFileInPackage = (packageName, ...pathElements) => {
   return require.resolve(path.join(packageName, ...pathElements));
 };
 
-/**
- * @func resolveDirInPackage
- * Resolves a file inside a package
- */
-const resolveDirInPackage = (packageName, ...pathElements) => {
-  return path.dirname(resolveFileInPackage(packageName, ...pathElements));
-};
-
 /**
  * @func resolvePackageFolder
  * Resolves the location of a package on disc
@@ -26,6 +18,14 @@ const resolvePackageFolder = packageName => {
   return path.dirname(resolveFileInPackage(packageName, 'package.json'));
 };
 
+/**
+ * @func resolveDirInPackage
+ * Resolves a file inside a package
+ */
+const resolveDirInPackage = (packageName, ...pathElements) => {
+  return path.join(resolvePackageFolder(packageName), ...pathElements);
+};
+
 module.exports = {
   resolveFileInPackage,
   resolveDirInPackage,

packages/development-edition-engine-handlebars/package.json

@@ -8,6 +8,7 @@
     "pl:help": "patternlab --help",
     "pl:install": "patternlab install --config ./patternlab-config.json",
     "pl:serve": "patternlab serve --config ./patternlab-config.json",
+    "pl:starterkit": "patternlab add --starterkits @pattern-lab/starterkit-handlebars-vanilla",
     "pl:version": "patternlab --version",
     "dev": "node ./node_modules/@pattern-lab/uikit-workshop/build-tools.js"
   },
@@ -33,6 +34,7 @@
     "@pattern-lab/engine-handlebars": "^5.10.1",
     "@pattern-lab/engine-mustache": "^5.12.0",
     "@pattern-lab/plugin-tab": "^5.10.1",
+    "@pattern-lab/starterkit-handlebars-vanilla": "1.4.0",
     "@pattern-lab/starterkit-mustache-demo": "^5.0.0",
     "@pattern-lab/uikit-workshop": "^5.12.0"
   }