Skip to content

Commit 6114b54

Browse files
committed
updates ACL tests
1 parent e3e599e commit 6114b54

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ACannedACLs.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ protected Configuration createConfiguration() {
5555
Configuration conf = super.createConfiguration();
5656
removeBaseAndBucketOverrides(conf,
5757
CANNED_ACL);
58-
58+
// TODO: Check why we need this ACL? V2 does not have a LOG_DELIVERY_WRITE ACL which causes
59+
// this test to fail.
5960
conf.set(CANNED_ACL, LOG_DELIVERY_WRITE);
6061
// needed because of direct calls made
6162
conf.setBoolean(S3AAuditConstants.REJECT_OUT_OF_SPAN_OPERATIONS, false);

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/delegation/ITestSessionDelegationInFileystem.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ protected Configuration createConfiguration() {
175175
conf.set(YarnConfiguration.RM_PRINCIPAL, YARN_RM);
176176
// turn on ACLs so as to verify role DT permissions include
177177
// write access.
178-
// TODO: CHECK WHY???
179-
conf.set(CANNED_ACL, LOG_DELIVERY_WRITE);
178+
// TODO: Why do we need this? Can we get rid of ACLs?
179+
// conf.set(CANNED_ACL, LOG_DELIVERY_WRITE);
180180
return conf;
181181
}
182182

0 commit comments

Comments
 (0)