Skip to content

Conversation

@trueleo
Copy link
Contributor

@trueleo trueleo commented Aug 16, 2022

Fixes #40.

Description

This PR fixes time subtraction when adjusting for OBJECT_STORE_DATA_GRANULARITY. By letting chrono subtract minutes from StorageSync time we can ensure right date and time for file URI


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@trueleo trueleo marked this pull request as ready for review August 16, 2022 17:34
@nitisht nitisht merged commit 4945757 into parseablehq:main Aug 17, 2022
@trueleo trueleo deleted the chrono_fix branch August 17, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in storage upload flow

2 participants