From 9171a4e88c43021f6dbc0ca985afee86087154e3 Mon Sep 17 00:00:00 2001 From: Satyam Singh Date: Wed, 4 Jan 2023 18:39:33 +0530 Subject: [PATCH] Fix banner if fetching latest release fails --- server/src/banner.rs | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/server/src/banner.rs b/server/src/banner.rs index 64c7099ef..cdca91f78 100644 --- a/server/src/banner.rs +++ b/server/src/banner.rs @@ -101,24 +101,10 @@ pub mod about { current_version, ); - // check for latest release, if it cannot be fetched then print error as warn and return - let latest_release = match update::get_latest() { - Ok(latest_release) => latest_release, - Err(_) => { - return; + if let Ok(latest_release) = update::get_latest() { + if latest_release.version > current_version { + print_latest_release(latest_release); } - }; - - if latest_release.version > current_version { - let time_since_latest_release = chrono::Utc::now() - latest_release.date; - let time_since_latest_release = humanize_time(time_since_latest_release); - - let fmt_latest_version = format!( - " ( v{} released {} ago. Download new release from https://github.com/parseablehq/parseable/releases/latest )", - latest_release.version, time_since_latest_release - ); - - eprint!("{}", fmt_latest_version.red()); } eprintln!( @@ -129,6 +115,16 @@ pub mod about { ); } + fn print_latest_release(latest_release: update::LatestRelease) { + let time_since_latest_release = chrono::Utc::now() - latest_release.date; + let time_since_latest_release = humanize_time(time_since_latest_release); + let fmt_latest_version = format!( + " ( v{} released {} ago. Download new release from https://github.com/parseablehq/parseable/releases/latest )", + latest_release.version, time_since_latest_release + ); + eprint!("{}", fmt_latest_version.red()); + } + pub fn print() { // print current version let current = current();