Skip to content

refactor: reuse TimeRange #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2025
Merged

refactor: reuse TimeRange #1146

merged 4 commits into from
Jan 31, 2025

Conversation

@de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 29, 2025

Fixes #XXXX.

Description

Reuse TimeRange instead of having two structs

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

nikhilsinhaparseable
nikhilsinhaparseable approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 02a89cd into parseablehq:main Jan 31, 2025
11 checks passed
@de-sh de-sh deleted the generate-prefix branch January 31, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@de-sh @nikhilsinhaparseable @nitisht