split arrow conversion and sync #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13004371562Details
💛 - Coveralls |
parmesant
force-pushed
the
sync-warning
branch
from
bc40cf2 to
813ede8
Compare
src/storage/object_storage.rs
Outdated
| let streams = STREAM_INFO.list_streams(); | ||
|
|
||
| // start the sync loop for a stream | ||
| // parallelize this |
Contributor
There was a problem hiding this comment.
please implement the code for parallelization for each stream in both sync and conversion flow
src/storage/object_storage.rs
Outdated
|
|
||
| // read arrow files on disk | ||
| // convert them to parquet | ||
| let schema = convert_disk_files_to_parquet( |
Contributor
There was a problem hiding this comment.
why are we still converting arrow to parquet in sync flow
Returning None based on length of vec for proper message printing
Upload and conversion tasks are handled by a monitor task which checks whether these tasks have crossed a threshold or not. In case either of these tasks crosses a pre-defined threshold, a warning will be printed.
parmesant
force-pushed
the
sync-warning
branch
from
37aa68d to
cdd863a
Compare
perf: consume less CPU cycles, by understanding tokio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates out the arrow conversion job from the sync job as we require more visibility into both of them. Arrow to Parquet conversion takes place at the 5th second of every minute and sync/upload happens every 30 seconds. Nothing else has been changed in terms of functionality.
Description
This PR has: