From 0aa4fd80a22f1432ac7eba9dec12b6163fa036cd Mon Sep 17 00:00:00 2001 From: Devdutt Shenoi Date: Mon, 20 Jan 2025 20:14:08 +0530 Subject: [PATCH 1/2] fix: run `fields_mismatch` against `static_schema` data also --- src/event/format/json.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/event/format/json.rs b/src/event/format/json.rs index c0be9320d..8e12a74f5 100644 --- a/src/event/format/json.rs +++ b/src/event/format/json.rs @@ -94,8 +94,7 @@ impl EventFormat for Event { } }; - if !static_schema_flag - && value_arr + if value_arr .iter() .any(|value| fields_mismatch(&schema, value, schema_version)) { From f2f8e053c56043fef9f55808a019e60a123cf144 Mon Sep 17 00:00:00 2001 From: Devdutt Shenoi Date: Mon, 20 Jan 2025 21:48:00 +0530 Subject: [PATCH 2/2] chore: remove unused param --- src/event/format/json.rs | 1 - src/event/format/mod.rs | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/event/format/json.rs b/src/event/format/json.rs index 8e12a74f5..71fcaffc7 100644 --- a/src/event/format/json.rs +++ b/src/event/format/json.rs @@ -44,7 +44,6 @@ impl EventFormat for Event { fn to_data( self, schema: &HashMap>, - static_schema_flag: bool, time_partition: Option<&String>, schema_version: SchemaVersion, ) -> Result<(Self::Data, Vec>, bool), anyhow::Error> { diff --git a/src/event/format/mod.rs b/src/event/format/mod.rs index 4032c92fa..e344d0060 100644 --- a/src/event/format/mod.rs +++ b/src/event/format/mod.rs @@ -81,7 +81,6 @@ pub trait EventFormat: Sized { fn to_data( self, schema: &HashMap>, - static_schema_flag: bool, time_partition: Option<&String>, schema_version: SchemaVersion, ) -> Result<(Self::Data, EventSchema, bool), AnyError>; @@ -97,7 +96,6 @@ pub trait EventFormat: Sized { ) -> Result<(RecordBatch, bool), AnyError> { let (data, mut schema, is_first) = self.to_data( storage_schema, - static_schema_flag, time_partition, schema_version, )?;