fix: allow multiple tags in dashboards list_by_tag API

Author: nikhilsinhaparseable

src/handlers/http/modal/server.rs

@@ -308,9 +308,9 @@ impl Server {
                 ),
             )
             .service(
-                web::resource("/list_by_tag/{tag}").route(
+                web::resource("/list_by_tag/{tags}").route(
                     web::get()
-                        .to(dashboards::list_dashboards_by_tag)
+                        .to(dashboards::list_dashboards_by_tags)
                         .authorize(Action::ListDashboard),
                 ),
             )

src/handlers/http/users/dashboards.rs

@@ -203,13 +203,21 @@ pub async fn list_tags() -> Result<impl Responder, DashboardError> {
     Ok((web::Json(tags), StatusCode::OK))
 }
 
-pub async fn list_dashboards_by_tag(tag: Path<String>) -> Result<impl Responder, DashboardError> {
-    let tag = tag.into_inner();
-    if tag.is_empty() {
-        return Err(DashboardError::Metadata("Tag cannot be empty"));
+pub async fn list_dashboards_by_tags(tags: Path<String>) -> Result<impl Responder, DashboardError> {
+    let tags = tags.into_inner();
+    if tags.is_empty() {
+        return Err(DashboardError::Metadata("Tags cannot be empty"));
     }
-
-    let dashboards = DASHBOARDS.list_dashboards_by_tag(&tag).await;
+    // tags can be comma separated list of tags
+    let tags = tags
+        .split(',')
+        .map(|s| s.trim().to_string())
+        .filter(|s| !s.is_empty())
+        .collect::<Vec<_>>();
+    if tags.is_empty() {
+        return Err(DashboardError::Metadata("Tags cannot be empty"));
+    }
+    let dashboards = DASHBOARDS.list_dashboards_by_tags(tags).await;
     let dashboard_summaries = dashboards
         .iter()
         .map(|dashboard| dashboard.to_summary())

src/users/dashboards.rs

@@ -364,14 +364,16 @@ impl Dashboards {
 
     /// List dashboards by tag
     /// This function returns a list of dashboards that have the specified tag
-    pub async fn list_dashboards_by_tag(&self, tag: &str) -> Vec<Dashboard> {
+    pub async fn list_dashboards_by_tags(&self, tags: Vec<String>) -> Vec<Dashboard> {
         let dashboards = self.0.read().await;
         dashboards
             .iter()
             .filter(|d| {
-                d.tags
-                    .as_ref()
-                    .is_some_and(|tags| tags.contains(&tag.to_string()))
+                if let Some(dashboard_tags) = &d.tags {
+                    !tags.is_empty() && dashboard_tags.iter().any(|tag| tags.contains(tag))
+                } else {
+                    false
+                }
             })
             .cloned()
             .collect()