Coderabbit suggestions

Author: parmesant

src/utils/mod.rs

@@ -29,7 +29,7 @@ use crate::handlers::http::rbac::RBACError;
 use crate::parseable::PARSEABLE;
 use crate::query::{TableScanVisitor, QUERY_SESSION};
 use crate::rbac::map::SessionKey;
-use crate::rbac::role::{Action, Permission};
+use crate::rbac::role::{Action, ParseableResourceType, Permission};
 use crate::rbac::Users;
 use actix::extract_session_key_from_req;
 use actix_web::HttpRequest;
@@ -114,22 +114,31 @@ pub fn user_auth_for_datasets(
                     authorized = true;
                     break;
                 }
-                Permission::Resource(
-                    Action::Query,
-                    crate::rbac::role::ParseableResourceType::Stream(stream),
-                ) => {
-                    let is_internal = PARSEABLE
-                        .get_stream(&table_name)
-                        .is_ok_and(|stream|stream.get_stream_type().eq(&crate::storage::StreamType::Internal));
-                    
-                    if stream == table_name
-                        || stream == "*"
-                        || is_internal
-                    {
+                Permission::Resource(Action::Query, ParseableResourceType::Stream(stream)) => {
+                    let is_internal = PARSEABLE.get_stream(table_name).is_ok_and(|stream| {
+                        stream
+                            .get_stream_type()
+                            .eq(&crate::storage::StreamType::Internal)
+                    });
+
+                    if stream == table_name || stream == "*" || is_internal {
                         authorized = true;
                     }
                 }
-                Permission::Resource(_, crate::rbac::role::ParseableResourceType::All) => {
+                Permission::Resource(action, ParseableResourceType::All)
+                    if ![
+                        Action::All,
+                        Action::PutUser,
+                        Action::PutRole,
+                        Action::DeleteUser,
+                        Action::DeleteRole,
+                        Action::ModifyUserGroup,
+                        Action::CreateUserGroup,
+                        Action::DeleteUserGroup,
+                        Action::DeleteNode,
+                    ]
+                    .contains(action) =>
+                {
                     authorized = true;
                 }
                 _ => (),