update list filters to support save view in prism

do not skip if query string is empty
update user access to the dataset instead of query string for filters

Author: nikhilsinhaparseable

src/users/filters.rs

@@ -185,18 +185,18 @@ impl Filters {
             let query = if let Some(q) = &f.query.filter_query {
                 q
             } else {
-                continue;
+                &String::default()
             };
             let filter_type = &f.query.filter_type;
 
             // if filter type is one of SQL or filter
             // then check if the user has access to the dataset based on the query string
             // if filter type is search then check if the user has access to the dataset based on the dataset name
-            if *filter_type == FilterType::SQL || *filter_type == FilterType::Filter {
+            if *filter_type == FilterType::SQL {
                 if (user_auth_for_query(key, query).await).is_ok() {
                     filters.push(f.clone())
                 }
-            } else if *filter_type == FilterType::Search {
+            } else if *filter_type == FilterType::Search || *filter_type == FilterType::Filter {
                 let dataset_name = &f.stream_name;
                 let permissions = Users.get_permissions(key);
                 if user_auth_for_datasets(&permissions, &[dataset_name.to_string()]).is_ok() {