chore: cleanup

Author: Eshanatnight

server/src/handlers/http/modal/ingest_server.rs

@@ -104,7 +104,6 @@ impl ParseableServer for IngestServer {
         self.initialize().await
     }
 
-    #[allow(unused)]
     fn validate(&self) -> anyhow::Result<()> {
         if CONFIG.get_storage_mode_string() == "Local drive" {
             return Err(anyhow::Error::msg(
@@ -229,7 +228,7 @@ impl IngestServer {
             DEFAULT_VERSION.to_string(),
             store.get_bucket_name(),
             &CONFIG.parseable.username,
-            &CONFIG.parseable.password, // is this secure?
+            &CONFIG.parseable.password,
         );
 
         let resource = serde_json::to_string(&resource)

server/src/handlers/http/modal/query_server.rs

@@ -112,7 +112,6 @@ impl ParseableServer for QueryServer {
         self.initialize().await
     }
 
-    #[allow(unused)]
     fn validate(&self) -> anyhow::Result<()> {
         if CONFIG.get_storage_mode_string() == "Local drive" {
             return Err(anyhow::anyhow!(

server/src/main.rs

@@ -67,11 +67,7 @@ async fn main() -> anyhow::Result<()> {
         Mode::All => Arc::new(Server),
     };
 
-    // add logic for graceful shutdown if
     // MODE == Query / Ingest and storage = local-store
-    // option.rs ln: 161
-    // CONFIG.run_time_mode_validation()?;
-
     server.init().await?;
 
     Ok(())

server/src/option.rs

@@ -157,18 +157,6 @@ impl Config {
         }
         "S3 bucket"
     }
-
-    #[allow(dead_code)]
-    pub fn run_time_mode_validation(&self) -> anyhow::Result<()> {
-        let check = (self.parseable.mode == Mode::Ingest || self.parseable.mode == Mode::Query)
-            && self.storage_name == "drive";
-
-        if check {
-            anyhow::bail!(format!("Cannot start the server in {} mode with local storage, please use S3 bucket for storage", self.parseable.mode.to_str()))
-        }
-
-        Ok(())
-    }
 }
 
 fn create_parseable_cli_command() -> Command {