refactor: declutter by separating out into #1239

Author: Devdutt Shenoi

src/parseable/streams.rs

@@ -32,7 +32,6 @@ use arrow_schema::{Field, Fields, Schema};
 use chrono::{NaiveDateTime, Timelike, Utc};
 use derive_more::{Deref, DerefMut};
 use itertools::Itertools;
-use once_cell::sync::Lazy;
 use parquet::{
     arrow::ArrowWriter,
     basic::Encoding,
@@ -41,7 +40,6 @@ use parquet::{
     schema::types::ColumnPath,
 };
 use rand::distributions::DistString;
-use regex::Regex;
 use relative_path::RelativePathBuf;
 use tokio::task::JoinSet;
 use tracing::{error, info, trace, warn};
@@ -72,41 +70,6 @@ use super::{
 // ~16K rows is default in-memory limit for each recordbatch
 const MAX_RECORD_BATCH_SIZE: usize = 16384;
 
-/// Regex pattern for parsing arrow file names.
-///
-/// # Format
-/// The expected format is: `<schema_key>.<front_part>.data.arrows`
-/// where:
-/// - schema_key: A key that is associated with the timestamp at ingestion, hash of arrow schema and the key-value
-///               pairs joined by '&' and '=' (e.g., "20200201T1830f8a5fc1edc567d56&key1=value1&key2=value2")
-/// - front_part: Captured for parquet file naming, contains the timestamp associted with current/time-partition
-///               as well as the custom partitioning key=value pairs (e.g., "date=2020-01-21.hour=10.minute=30.key1=value1.key2=value2.ee529ffc8e76")
-///
-/// # Limitations
-/// - Partition keys and values must only contain alphanumeric characters
-/// - Special characters in partition values will cause the pattern to fail in capturing
-///
-/// # Examples
-/// Valid: "key1=value1,key2=value2"
-/// Invalid: "key1=special!value,key2=special#value"
-static ARROWS_NAME_STRUCTURE: Lazy<Regex> = Lazy::new(|| {
-    Regex::new(r"^[a-zA-Z0-9&=]+\.(?P<front>\S+)\.data\.arrows$").expect("Validated regex")
-});
-
-/// Returns the filename for parquet if provided arrows file path is valid as per our expectation
-fn arrow_path_to_parquet(path: &Path, random_string: &str) -> Option<PathBuf> {
-    let filename = path.file_name().unwrap().to_str().unwrap();
-    let filename = ARROWS_NAME_STRUCTURE
-        .captures(filename)
-        .and_then(|c| c.get(1))?
-        .as_str();
-    let filename_with_random_number = format!("{filename}.data.{random_string}.parquet");
-    let mut parquet_path = path.to_owned();
-    parquet_path.set_file_name(filename_with_random_number);
-
-    Some(parquet_path)
-}
-
 #[derive(Debug, thiserror::Error)]
 #[error("Stream not found: {0}")]
 pub struct StreamNotFound(pub String);
@@ -228,12 +191,7 @@ impl Stream {
         let paths = dir
             .flatten()
             .map(|file| file.path())
-            .filter(|path| {
-                let Some(file_name) = path.file_name().and_then(|f| f.to_str()) else {
-                    return false;
-                };
-                ARROWS_NAME_STRUCTURE.is_match(file_name)
-            })
+            .filter(|file| file.extension().is_some_and(|ext| ext.eq("arrows")))
             .sorted_by_key(|f| f.metadata().unwrap().modified().unwrap())
             .collect();
 
@@ -276,13 +234,12 @@ impl Stream {
                     &arrow_file_path, self.stream_name
                 );
                 remove_file(&arrow_file_path).unwrap();
-            } else if let Some(key) = arrow_path_to_parquet(&arrow_file_path, &random_string) {
+            } else {
+                let key = Self::arrow_path_to_parquet(&arrow_file_path, &random_string);
                 grouped_arrow_file
                     .entry(key)
                     .or_default()
                     .push(arrow_file_path);
-            } else {
-                warn!("Unexpected arrows file: {}", arrow_file_path.display());
             }
         }
         grouped_arrow_file
@@ -341,6 +298,17 @@ impl Stream {
         }
     }
 
+    fn arrow_path_to_parquet(path: &Path, random_string: &str) -> PathBuf {
+        let filename = path.file_stem().unwrap().to_str().unwrap();
+        let (_, filename) = filename.split_once('.').unwrap();
+        assert!(filename.contains('.'), "contains the delim `.`");
+        let filename_with_random_number = format!("{filename}.{random_string}.arrows");
+        let mut parquet_path = path.to_owned();
+        parquet_path.set_file_name(filename_with_random_number);
+        parquet_path.set_extension("parquet");
+        parquet_path
+    }
+
     /// Converts arrow files in staging into parquet files, does so only for past minutes when run with `!shutdown_signal`
     pub fn prepare_parquet(&self, shutdown_signal: bool) -> Result<(), StagingError> {
         info!(