restrict updating hot tier for internal stream

nikhilsinhaparseable · nikhilsinhaparseable · commit 44a667c84293 · 2024-08-13T16:59:42.000+05:30
diff --git a/server/src/handlers/http/logstream.rs b/server/src/handlers/http/logstream.rs
@@ -957,6 +957,13 @@ pub async fn put_stream_hot_tier(
     if !metadata::STREAM_INFO.stream_exists(&stream_name) {
         return Err(StreamError::StreamNotFound(stream_name));
     }
+
+    if stream_name.eq(INTERNAL_STREAM_NAME) {
+        return Err(StreamError::Custom {
+            msg: "Hot tier can not be updated for internal stream".to_string(),
+            status: StatusCode::BAD_REQUEST,
+        });
+    }
     if CONFIG.parseable.hot_tier_storage_path.is_none() {
         return Err(StreamError::HotTierNotEnabled(stream_name));
     }

Original file line number	Diff line number	Diff line change
`@@ -957,6 +957,13 @@ pub async fn put_stream_hot_tier(`
`957`	`957`	`if !metadata::STREAM_INFO.stream_exists(&stream_name) {`
`958`	`958`	`return Err(StreamError::StreamNotFound(stream_name));`
`959`	`959`	`}`
	`960`	`+`
	`961`	`+ if stream_name.eq(INTERNAL_STREAM_NAME) {`
	`962`	`+ return Err(StreamError::Custom {`
	`963`	`+ msg: "Hot tier can not be updated for internal stream".to_string(),`
	`964`	`+ status: StatusCode::BAD_REQUEST,`
	`965`	`+ });`
	`966`	`+ }`
`960`	`967`	`if CONFIG.parseable.hot_tier_storage_path.is_none() {`
`961`	`968`	`return Err(StreamError::HotTierNotEnabled(stream_name));`
`962`	`969`	`}`