code rabbit suggestions

Author: nikhilsinhaparseable

src/handlers/http/rbac.rs

@@ -224,7 +224,7 @@ pub async fn get_role(userid: web::Path<String>) -> Result<impl Responder, RBACE
 // Handler for DELETE /api/v1/user/delete/{userid}
 pub async fn delete_user(userid: web::Path<String>) -> Result<impl Responder, RBACError> {
     let userid = userid.into_inner();
-
+    let _guard = UPDATE_LOCK.lock().await;
     // if user is a part of any groups then don't allow deletion
     if !Users.get_user_groups(&userid).is_empty() {
         return Err(RBACError::InvalidDeletionRequest(format!(
@@ -243,8 +243,6 @@ pub async fn delete_user(userid: web::Path<String>) -> Result<impl Responder, RB
         return Err(RBACError::UserDoesNotExist);
     };
 
-    let _guard = UPDATE_LOCK.lock().await;
-
     // delete from parseable.json first
     let mut metadata = get_metadata().await?;
     metadata.users.retain(|user| user.userid() != userid);

src/rbac/user.rs

@@ -407,10 +407,7 @@ impl UserGroup {
 
     /// Get all user IDs in this group
     pub fn get_userids(&self) -> Vec<String> {
-        self.users
-            .iter()
-            .map(|u| u.userid().to_string())
-            .collect()
+        self.users.iter().map(|u| u.userid().to_string()).collect()
     }
 
     /// Add users by converting from User references