Update PostgresStorageAdapter.js #6981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start moving toward better, ES7 syntax.
|
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #6981 +/- ##
==========================================
- Coverage 93.81% 93.81% -0.01%
==========================================
Files 169 169
Lines 12402 12409 +7
==========================================
+ Hits 11635 11641 +6
- Misses 767 768 +1
Continue to review full report at Codecov.
|
Fixing spaces 🤦♂️
Contributor
Author
|
After an unsuccessful build... I don't know why it is failing, but it doesn't seem related to these changes. |
Member
|
There are some false positive tests. You can restart Travis jobs |
Contributor
Author
My account doesn't seem to have the permission to restart Travis jobs for this project. |
davimacedo
approved these changes
Oct 30, 2020
dblythy
pushed a commit
to dblythy/parse-server
that referenced
this pull request
Dec 14, 2020
* Update PostgresStorageAdapter.js Start moving toward better, ES7 syntax. * Update PostgresStorageAdapter.js Fixing spaces 🤦♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start moving toward better, ES7 syntax.
In this case, the batch is not needed, and it is better to use ES7 syntax, to avoid creating other requests, if a previous one fails.