Update CONTRIBUTING.md to include test-running instructions #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONTRIBUTING.md
Outdated
| * Please write tests to cover new methods. | ||
| * Please run the tests and make sure you didn't break anything. | ||
| * Take testing seriously! Aim to increase the test coverage with every pull request. | ||
| * Run the tests for the file you are working on with `TESTING=1 ./node_modules/jasmine/bin/jasmine.js --filter="MyFile"` (from repo root) |
Contributor
There was a problem hiding this comment.
Running a single spec file is done like this:
TESTING=1 ./node_modules/jasmine/bin/jasmine.js spec/ParseFile.spec.js
|
@drew-gross updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
drew-gross
added a commit
that referenced
this pull request
Feb 6, 2016
Update CONTRIBUTING.md to include test-running instructions
Contributor
Author
|
Flaky mongo tests. Merging despite failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.