Fix maxlimit validation logic to correctly handle maxLimit:0 case

cnorris · cnorris · commit efa9e7b2405e · 2017-07-26T12:56:30.000-07:00
diff --git a/src/Config.js b/src/Config.js
@@ -225,10 +225,8 @@ export class Config {
   }
 
   static validateMaxLimit(maxLimit) {
-    if (maxLimit) {
-      if (maxLimit <= 0) {
-        throw 'Max limit must be a value greater than 0.'
-      }
+    if (maxLimit <= 0) {
+      throw 'Max limit must be a value greater than 0.'
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -225,10 +225,8 @@ export class Config {`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`static validateMaxLimit(maxLimit) {`
`228`		`- if (maxLimit) {`
`229`		`- if (maxLimit <= 0) {`
`230`		`- throw 'Max limit must be a value greater than 0.'`
`231`		`- }`
	`228`	`+ if (maxLimit <= 0) {`
	`229`	`+ throw 'Max limit must be a value greater than 0.'`
`232`	`230`	`}`
`233`	`231`	`}`
`234`	`232`