and here's what it looks like with a 1 line max

Arthur Cinader · Arthur Cinader · commit dabe3e28d45b · 2016-12-04T10:55:45.000-08:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -19,6 +19,6 @@
         "no-trailing-spaces": 2,
         "eol-last": 2,
         "space-in-parens": ["error", "never"],
-        "no-multiple-empty-lines": 1
+        "no-multiple-empty-lines": ["warn", { "max": 1 }]
     }
 }
diff --git a/spec/CacheController.spec.js b/spec/CacheController.spec.js
@@ -16,7 +16,6 @@ describe('CacheController', function() {
     spyOn(FakeCacheAdapter, 'get').and.callThrough();
   });
 
-
   it('should expose role and user caches', (done) => {
     var cache = new CacheController(FakeCacheAdapter, FakeAppID);
 
@@ -28,7 +27,6 @@ describe('CacheController', function() {
     done();
   });
 
-
   ['role', 'user'].forEach((cacheName) => {
     it('should prefix ' + cacheName + ' cache', () => {
       var cache = new CacheController(FakeCacheAdapter, FakeAppID)[cacheName];
diff --git a/spec/Client.spec.js b/spec/Client.spec.js
@@ -76,7 +76,6 @@ describe('Client', function() {
     expect(client.subscriptionInfos.size).toBe(0);
   });
 
-
   it('can generate ParseObject JSON with null selected field', function() {
     var parseObjectJSON = {
       key : 'value',
diff --git a/spec/FilesController.spec.js b/spec/FilesController.spec.js
@@ -2,7 +2,6 @@ var GridStoreAdapter = require("../src/Adapters/Files/GridStoreAdapter").GridSto
 var Config = require("../src/Config");
 var FilesController = require('../src/Controllers/FilesController').default;
 
-
 // Small additional tests to improve overall coverage
 describe("FilesController",() =>{
   it("should properly expand objects", (done) => {
diff --git a/spec/GridStoreAdapter.js b/spec/GridStoreAdapter.js
@@ -5,7 +5,6 @@ var GridStoreAdapter = require("../src/Adapters/Files/GridStoreAdapter").GridSto
 var Config = require("../src/Config");
 var FilesController = require('../src/Controllers/FilesController').default;
 
-
 // Small additional tests to improve overall coverage
 describe_only_db('mongo')("GridStoreAdapter",() =>{
   it("should properly instanciate the GridStore when deleting a file", (done) => {
@@ -31,7 +30,6 @@ describe_only_db('mongo')("GridStoreAdapter",() =>{
       return originalUnlink.call(this);
     };
 
-
     filesController.createFile(config, 'myFilename.txt', 'my file content', 'text/plain')
       .then(myFile => {
 
diff --git a/spec/HTTPRequest.spec.js b/spec/HTTPRequest.spec.js
@@ -35,7 +35,6 @@ app.get('/qs', function(req, res){
 
 app.listen(13371);
 
-
 describe("httpRequest", () => {
   it("should do /hello", (done) => {
     httpRequest({
diff --git a/spec/InMemoryCache.spec.js b/spec/InMemoryCache.spec.js
@@ -1,6 +1,5 @@
 const InMemoryCache = require('../src/Adapters/Cache/InMemoryCache').default;
 
-
 describe('InMemoryCache', function() {
   var BASE_TTL = {
     ttl: 10
@@ -13,7 +12,6 @@ describe('InMemoryCache', function() {
 
   var VALUE = 'world';
 
-
   function wait(sleep) {
     return new Promise(function(resolve) {
       setTimeout(resolve, sleep);
diff --git a/spec/Middlewares.spec.js b/spec/Middlewares.spec.js
@@ -65,7 +65,6 @@ describe('middlewares', () => {
     expect(fakeRes.status).toHaveBeenCalledWith(403);
   });
 
-
   it('should succeed when any one of the configured keys supplied', (done) => {
     AppCache.put(fakeReq.body._ApplicationId, {
       clientKey: 'clientKey',
diff --git a/spec/MongoStorageAdapter.spec.js b/spec/MongoStorageAdapter.spec.js
@@ -199,7 +199,6 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       date: { type: 'Date' },
     } };
 
-
     adapter.createObject('MyClass', schema, {})
     .then(() => adapter._rawFind('MyClass', {}))
     .then(results => {
diff --git a/spec/OAuth.spec.js b/spec/OAuth.spec.js
@@ -74,7 +74,6 @@ describe('OAuth', function() {
     done();
   });
 
-
   function validateCannotAuthenticateError(data, done) {
     jequal(typeof data, "object");
     jequal(typeof data.errors, "object");
@@ -325,5 +324,4 @@ describe('OAuth', function() {
     });
   });
 
-
 })
diff --git a/spec/ParseFile.spec.js b/spec/ParseFile.spec.js
@@ -36,7 +36,6 @@ describe('Parse.File testing', () => {
       });
     });
 
-
     it('works with _ContentType', done => {
 
       request.post({
diff --git a/spec/ParseHooks.spec.js b/spec/ParseHooks.spec.js
@@ -238,7 +238,6 @@ describe('Hooks', () => {
     });
   });
 
-
   it("should fail trying to create a malformed function", (done) => {
     Parse.Hooks.createFunction("MyFunction").then((res) => {
       fail(res);
@@ -268,7 +267,6 @@ describe('Hooks', () => {
     })
   });
 
-
   it("should create hooks and properly preload them", (done) => {
 
     var promises = [];
@@ -410,7 +408,6 @@ describe('Hooks', () => {
      });
   });
 
-
   it("should run the beforeSave hook on the test server", (done) => {
     var triggerCount = 0;
     app.post("/BeforeSaveSome", function(req, res) {
diff --git a/spec/ParseObject.spec.js b/spec/ParseObject.spec.js
@@ -1830,7 +1830,6 @@ describe('Parse.Object testing', () => {
     });
   });
 
-
   it("should create nested keys with _", done => {
     const object = new Parse.Object("AnObject");
     object.set("foo", {
diff --git a/spec/ParseQuery.spec.js b/spec/ParseQuery.spec.js
@@ -41,7 +41,6 @@ describe('Parse.Query testing', () => {
     var cake2 = new Cake();
     var cake3 = new Cake();
 
-
     user.signUp().then(function(){
       return user1.signUp();
     }).then(function(){
@@ -544,7 +543,6 @@ describe('Parse.Query testing', () => {
       });
   });
 
-
   it("objectId containedIn queries", function(done) {
     var makeBoxedNumber = function(i) {
       return new BoxedNumber({ number: i });
@@ -2453,7 +2451,6 @@ describe('Parse.Query testing', () => {
       var matchRelationshipB = new Parse.Query("_User");
       matchRelationshipB.matchesKeyInQuery("objectId", "userBObjectId", matchOr);
 
-
       var orQuery = Parse.Query.or(objIdQuery, blockedUserQuery, matchRelationshipA, matchRelationshipB);
       var query = new Parse.Query("_User");
       query.doesNotMatchQuery("objectId", orQuery);
diff --git a/spec/ParseRelation.spec.js b/spec/ParseRelation.spec.js
@@ -163,7 +163,6 @@ describe('Parse.Relation testing', () => {
     });
   });
 
-
   it_exclude_dbs(['postgres'])("queries with relations", (done) => {
 
     var ChildObject = Parse.Object.extend("ChildObject");
@@ -421,7 +420,6 @@ describe('Parse.Relation testing', () => {
     });
   });
 
-
   it("Get query on relation using un-fetched parent object", (done) => {
     // Setup data model
     var Wheel = Parse.Object.extend('Wheel');
diff --git a/spec/ParseUser.spec.js b/spec/ParseUser.spec.js
@@ -748,7 +748,6 @@ describe('Parse.User testing', () => {
     });
   });
 
-
   it("user loaded from localStorage from login", (done) => {
     var id;
     Parse.User.signUp("alice", "password").then((alice) => {
@@ -2562,7 +2561,6 @@ describe('Parse.User testing', () => {
     });
   });
 
-
   it('should aftersave with full object', (done) => {
     var hit = 0;
     Parse.Cloud.afterSave('_User', (req, res) => {
diff --git a/spec/PasswordPolicy.spec.js b/spec/PasswordPolicy.spec.js
@@ -1134,7 +1134,6 @@ describe("Password Policy: ", () => {
     });
   });
 
-
   it('should fail if the new password is same as the previous one', done => {
     const user = new Parse.User();
 
diff --git a/spec/PointerPermissions.spec.js b/spec/PointerPermissions.spec.js
@@ -45,7 +45,6 @@ describe('Pointer Permissions', () => {
     });
   });
 
-
   it('should work with write', (done) => {
     let config = new Config(Parse.applicationId);
     let user = new Parse.User();
@@ -614,7 +613,6 @@ describe('Pointer Permissions', () => {
     })
   });
 
-
   it('should let master key update objects', (done) => {
     let config = new Config(Parse.applicationId);
     let object = new Parse.Object('AnObject');
diff --git a/spec/UserPII.spec.js b/spec/UserPII.spec.js
@@ -63,7 +63,6 @@ describe('Personally Identifiable Information', () => {
       });
   });
 
-
   it('should be able to get own PII via API with Find', (done) => {
     new Parse.Query(Parse.User)
       .first()
@@ -101,7 +100,6 @@ describe('Personally Identifiable Information', () => {
       );
   });
 
-
   it('should be able to get own PII via API with Get', (done) => {
     new Parse.Query(Parse.User)
       .get(user.id)
@@ -304,7 +302,6 @@ describe('Personally Identifiable Information', () => {
         });
     });
 
-
     it('should be able to get own PII via API with Find', (done) => {
       new Parse.Query(Parse.User)
         .first()
@@ -342,7 +339,6 @@ describe('Personally Identifiable Information', () => {
         );
     });
 
-
     it('should be able to get own PII via API with Get', (done) => {
       new Parse.Query(Parse.User)
         .get(user.id)
diff --git a/spec/helper.js b/spec/helper.js
@@ -369,7 +369,6 @@ function mockFacebook() {
   return mockFacebookAuthenticator('8675309', 'jenny');
 }
 
-
 // This is polluting, but, it makes it way easier to directly port old tests.
 global.Parse = Parse;
 global.TestObject = TestObject;
@@ -419,7 +418,6 @@ global.describe_only_db = db => {
   }
 }
 
-
 var libraryCache = {};
 jasmine.mockLibrary = function(library, name, mock) {
   var original = require(library)[name];
diff --git a/src/Adapters/Cache/InMemoryCache.js b/src/Adapters/Cache/InMemoryCache.js
@@ -1,6 +1,5 @@
 const DEFAULT_CACHE_TTL = 5 * 1000;
 
-
 export class InMemoryCache {
   constructor({
     ttl = DEFAULT_CACHE_TTL
diff --git a/src/Adapters/Storage/Mongo/MongoSchemaCollection.js b/src/Adapters/Storage/Mongo/MongoSchemaCollection.js
@@ -82,7 +82,6 @@ function _mongoSchemaQueryFromNameQuery(name: string, query) {
   return object;
 }
 
-
 // Returns a type suitable for inserting into mongo _SCHEMA collection.
 // Does no validation. That is expected to be done in Parse Server.
 function parseFieldTypeToMongoFieldType({ type, targetClass }) {
diff --git a/src/Adapters/Storage/Mongo/MongoStorageAdapter.js b/src/Adapters/Storage/Mongo/MongoStorageAdapter.js
@@ -76,7 +76,6 @@ const mongoSchemaFromFieldsAndClassNameAndCLP = (fields, className, classLevelPe
   return mongoObject;
 }
 
-
 export class MongoStorageAdapter {
   // Private
   _uri: string;
diff --git a/src/Adapters/Storage/Mongo/MongoTransform.js b/src/Adapters/Storage/Mongo/MongoTransform.js
@@ -422,7 +422,6 @@ const addLegacyACL = restObject => {
   return restObjectCopy;
 }
 
-
 // A sentinel value that helper transformations return when they
 // cannot perform a transformation
 function CannotTransform() {}
diff --git a/src/Auth.js b/src/Auth.js
@@ -39,7 +39,6 @@ function nobody(config) {
   return new Auth({ config, isMaster: false });
 }
 
-
 // Returns a promise that resolves to an Auth object
 var getAuthForSessionToken = function({ config, sessionToken, installationId } = {}) {
   return config.cacheController.user.get(sessionToken).then((userJSON) => {
diff --git a/src/Controllers/CacheController.js b/src/Controllers/CacheController.js
@@ -39,7 +39,6 @@ export class SubCache {
   }
 }
 
-
 export class CacheController extends AdaptableController {
 
   constructor(adapter, appId, options = {}) {
diff --git a/src/LiveQuery/QueryTools.js b/src/LiveQuery/QueryTools.js
@@ -125,7 +125,6 @@ function equalObjectsGeneric(obj, compareTo, eqlFn) {
   return eqlFn(obj, compareTo);
 }
 
-
 /**
  * Determines whether an object matches a single key's constraints
  */
diff --git a/src/PromiseRouter.js b/src/PromiseRouter.js
@@ -25,7 +25,6 @@ function validateParameter(key, value) {
   }
 }
 
-
 export default class PromiseRouter {
   // Each entry should be an object with:
   // path: the path to route, in express format
@@ -195,7 +194,6 @@ function makeExpressHandler(appId, promiseHandler) {
   }
 }
 
-
 function maskSensitiveUrl(req) {
   let maskUrl = req.originalUrl.toString();
   let shouldMaskUrl = req.method === 'GET' && req.originalUrl.includes('/login')
diff --git a/src/RestWrite.js b/src/RestWrite.js
@@ -274,7 +274,6 @@ RestWrite.prototype.findUsersWithAuthData = function(authData) {
   return findPromise;
 }
 
-
 RestWrite.prototype.handleAuthData = function(authData) {
   let results;
   return this.handleAuthDataValidation(authData).then(() => {
@@ -340,7 +339,6 @@ RestWrite.prototype.handleAuthData = function(authData) {
   });
 }
 
-
 // The non-third-party parts of User transformation
 RestWrite.prototype.transformUser = function() {
   var promise = Promise.resolve();
@@ -443,7 +441,6 @@ RestWrite.prototype._validatePasswordPolicy = function() {
   });
 };
 
-
 RestWrite.prototype._validatePasswordRequirements = function() {
   // check if the password conforms to the defined password policy if configured
   const policyError = 'Password does not meet the Password Policy requirements.';
diff --git a/src/Routers/AnalyticsRouter.js b/src/Routers/AnalyticsRouter.js
@@ -11,7 +11,6 @@ function trackEvent(req) {
   return analyticsController.trackEvent(req);
 }
 
-
 export class AnalyticsRouter extends PromiseRouter {
   mountRoutes() {
     this.route('POST','/events/AppOpened', appOpened);
diff --git a/src/Routers/IAPValidationRouter.js b/src/Routers/IAPValidationRouter.js
@@ -55,7 +55,6 @@ function getFileForProductIdentifier(productIdentifier, req) {
   });
 }
 
-
 export class IAPValidationRouter extends PromiseRouter {
 
   handleRequest(req) {
diff --git a/src/Routers/UsersRouter.js b/src/Routers/UsersRouter.js
@@ -228,7 +228,6 @@ export class UsersRouter extends ClassesRouter {
     });
   }
 
-
   mountRoutes() {
     this.route('GET', '/users', req => { return this.handleFind(req); });
     this.route('POST', '/users', req => { return this.handleCreate(req); });
diff --git a/src/cli/definitions/parse-live-query-server.js b/src/cli/definitions/parse-live-query-server.js
diff --git a/src/cli/definitions/parse-server.js b/src/cli/definitions/parse-server.js
diff --git a/src/cli/parse-server.js b/src/cli/parse-server.js
diff --git a/src/triggers.js b/src/triggers.js

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,6 @@`
`19`	`19`	`"no-trailing-spaces": 2,`
`20`	`20`	`"eol-last": 2,`
`21`	`21`	`"space-in-parens": ["error", "never"],`
`22`		`- "no-multiple-empty-lines": 1`
	`22`	`+ "no-multiple-empty-lines": ["warn", { "max": 1 }]`
`23`	`23`	`}`
`24`	`24`	`}`