Throw error if $relativeTime is used with $exists, $ne, and $eq

Author: Marvel Mathew

spec/ParseQuery.spec.js

@@ -3119,8 +3119,7 @@ describe('Parse.Query testing', () => {
       ttl: new Date(now - 2 * 24 * 60 * 60 * 1000), // 2 days ago
     });
 
-    dropDatabase()
-      .then(() => Parse.Object.saveAll([obj1, obj2]))
+    Parse.Object.saveAll([obj1, obj2])
       .then(() => {
         const q = new Parse.Query('MyCustomObject');
         q.greaterThan('ttl', { $relativeTime: 'in 1 day' });
@@ -3164,7 +3163,20 @@ describe('Parse.Query testing', () => {
 
     const q = new Parse.Query('MyCustomObject');
     q.greaterThan('ttl', { $relativeTime: '-12 bananas ago' });
-    return obj1.save({ useMasterKey: true })
+    obj1.save({ useMasterKey: true })
+      .then(() => q.find({ useMasterKey: true }))
+      .then(done.fail, done);
+  });
+
+  it_only_db('mongo')('should error when using $relativeTime with $eq, $ne, and $', function(done) {
+    const obj1 = new Parse.Object('MyCustomObject', {
+      name: 'obj1',
+      ttl: new Date(Date.now() + 2 * 24 * 60 * 60 * 1000), // 2 days from now
+    });
+
+    const q = new Parse.Query('MyCustomObject');
+    q.exists('ttl', { $relativeTime: 'in 1 day' });
+    obj1.save({ useMasterKey: true })
       .then(() => q.find({ useMasterKey: true }))
       .then(done.fail, done);
   });

src/Adapters/Storage/Mongo/MongoTransform.js

@@ -673,7 +673,14 @@ function transformConstraint(constraint, field) {
     case '$ne':
     case '$eq': {
       const val = constraint[key];
-      if (key !== '$exists' && val && typeof val === 'object' && val.$relativeTime) {
+      if (val && typeof val === 'object' && val.$relativeTime) {
+        switch (key) {
+        case '$exists':
+        case '$ne':
+        case '$eq':
+          throw new Parse.Error(Parse.Error.INVALID_JSON, '$relativeTime can only be used with the $lt, $lte, $gt, and $gte operators');
+        }
+
         const parserResult = relativeTimeToDate(val.$relativeTime);
         if (parserResult.status === 'success') {
           answer[key] = parserResult.result;
@@ -684,7 +691,7 @@ function transformConstraint(constraint, field) {
         throw new Parse.Error(Parse.Error.INVALID_JSON, `bad $relativeTime (${key}) value. ${parserResult.info}`);
       }
 
-      answer[key] = transformer(constraint[key]);
+      answer[key] = transformer(val);
       break;
     }