Reverts to class by class deletion, introduced fast mode that just delete data for mongo

- Speeds up are incredible Executed 1695 of 1713 specs INCOMPLETE (18 PENDING) in 4 mins 19 secs.

Author: flovilmart

spec/MongoStorageAdapter.spec.js

@@ -9,7 +9,7 @@ const databaseURI = 'mongodb://localhost:27017/parseServerMongoAdapterTestDataba
 describe_only_db('mongo')('MongoStorageAdapter', () => {
   beforeEach(done => {
     new MongoStorageAdapter({ uri: databaseURI })
-      .dropDatabase()
+      .deleteAllClasses()
       .then(done, fail);
   });
 

spec/PostgresStorageAdapter.spec.js

@@ -12,7 +12,7 @@ const dropTable = (client, className) => {
 describe_only_db('postgres')('PostgresStorageAdapter', () => {
   const adapter = new PostgresStorageAdapter({ uri: databaseURI })
   beforeEach(() => {
-    return adapter.dropDatabase();
+    return adapter.deleteAllClasses();
   });
 
   it('schemaUpgrade, upgrade the database schema when schema changes', done => {

spec/helper.js

@@ -172,7 +172,7 @@ beforeEach(done => {
       throw error;
     }
   }
-  TestUtils.destroyAllDataPermanently()
+  TestUtils.destroyAllDataPermanently(true)
     .catch(error => {
     // For tests that connect to their own mongo, there won't be any data to delete.
       if (error.message === 'ns not found' || error.message.startsWith('connect ECONNREFUSED')) {
@@ -196,7 +196,7 @@ afterEach(function(done) {
       fail('There were open connections to the server left after the test finished');
     }
     on_db('postgres', () => {
-      TestUtils.destroyAllDataPermanently().then(done, done);
+      TestUtils.destroyAllDataPermanently(true).then(done, done);
     }, done);
   };
   Parse.Cloud._removeAllHooks();

src/Adapters/Storage/Mongo/MongoStorageAdapter.js

@@ -31,6 +31,22 @@ const MongoClient = mongodb.MongoClient;
 const ReadPreference = mongodb.ReadPreference;
 
 const MongoSchemaCollectionName = '_SCHEMA';
+
+const storageAdapterAllCollections = mongoAdapter => {
+  return mongoAdapter.connect()
+    .then(() => mongoAdapter.database.collections())
+    .then(collections => {
+      return collections.filter(collection => {
+        if (collection.namespace.match(/\.system\./)) {
+          return false;
+        }
+        // TODO: If you have one app with a collection prefix that happens to be a prefix of another
+        // apps prefix, this will go very very badly. We should fix that somehow.
+        return (collection.collectionName.indexOf(mongoAdapter._collectionPrefix) == 0);
+      });
+    });
+}
+
 const convertParseSchemaToMongoSchema = ({...schema}) => {
   delete schema.fields._rperm;
   delete schema.fields._wperm;
@@ -94,6 +110,7 @@ export class MongoStorageAdapter implements StorageAdapter {
   client: MongoClient;
   _maxTimeMS: ?number;
   canSortOnJoinTables: boolean;
+  collections: any;
 
   constructor({
     uri = defaults.DefaultMongoURI,
@@ -108,6 +125,7 @@ export class MongoStorageAdapter implements StorageAdapter {
     this._maxTimeMS = mongoOptions.maxTimeMS;
     this.canSortOnJoinTables = true;
     delete mongoOptions.maxTimeMS;
+    this.collections = {};
   }
 
   connect() {
@@ -163,10 +181,16 @@ export class MongoStorageAdapter implements StorageAdapter {
   }
 
   _adaptiveCollection(name: string) {
-    return this.connect()
-      .then(() => this.database.collection(this._collectionPrefix + name))
-      .then(rawCollection => new MongoCollection(rawCollection))
-      .catch(err => this.handleError(err));
+    if (!this.collections[name]) {
+      this.collections[name] = this.connect()
+        .then(() => this.database.collection(this._collectionPrefix + name))
+        .then(rawCollection => new MongoCollection(rawCollection))
+        .catch(err => {
+          delete this.collections[name];
+          this.handleError(err);
+        });
+    }
+    return this.collections[name];
   }
 
   _schemaCollection(): Promise<MongoSchemaCollection> {
@@ -297,9 +321,10 @@ export class MongoStorageAdapter implements StorageAdapter {
       .catch(err => this.handleError(err));
   }
 
-  dropDatabase() {
-    if (!this.database) { return Promise.resolve(); }
-    return this.database.dropDatabase();
+  deleteAllClasses(fast: boolean) {
+    return storageAdapterAllCollections(this)
+      .then(collections => Promise.all(collections.map(collection => fast ? collection.remove({}) : collection.drop())))
+      .catch(err => this.handleError(err));
   }
 
   // Remove the column and all the data. For Relations, the _Join collection is handled

src/Adapters/Storage/Postgres/PostgresStorageAdapter.js

@@ -959,10 +959,6 @@ export class PostgresStorageAdapter implements StorageAdapter {
       });
   }
 
-  dropDatabase() {
-    return this.deleteAllClasses();
-  }
-
   // Remove the column and all the data. For Relations, the _Join collection is handled
   // specially, this function does not delete _Join columns. It should, however, indicate
   // that the relation fields does not exist anymore. In mongo, this means removing it from

src/Adapters/Storage/StorageAdapter.js

@@ -31,7 +31,7 @@ export interface StorageAdapter {
   createClass(className: string, schema: SchemaType): Promise<void>;
   addFieldIfNotExists(className: string, fieldName: string, type: any): Promise<void>;
   deleteClass(className: string): Promise<void>;
-  dropDatabase(): Promise<void>;
+  deleteAllClasses(fast: boolean): Promise<void>;
   deleteFields(className: string, schema: SchemaType, fieldNames: Array<string>): Promise<void>;
   getAllClasses(): Promise<StorageClass[]>;
   getClass(className: string): Promise<StorageClass>;

src/Controllers/DatabaseController.js

@@ -655,10 +655,10 @@ class DatabaseController {
 
   // Won't delete collections in the system namespace
   // Returns a promise.
-  deleteEverything() {
+  deleteEverything(fast: boolean = false) {
     this.schemaPromise = null;
     return Promise.all([
-      this.adapter.dropDatabase(),
+      this.adapter.deleteAllClasses(fast),
       this.schemaCache.clear()
     ]);
   }

src/TestUtils.js

@@ -1,14 +1,14 @@
 import AppCache from './cache';
 
 //Used by tests
-export function destroyAllDataPermanently() {
+export function destroyAllDataPermanently(fast) {
   if (!process.env.TESTING) {
     throw 'Only supported in test environment';
   }
   return Promise.all(Object.keys(AppCache.cache).map(appId => {
     const app = AppCache.get(appId);
     if (app.databaseController) {
-      return app.databaseController.deleteEverything();
+      return app.databaseController.deleteEverything(fast);
     } else {
       return Promise.resolve();
     }