refactor fix

Author: mtrezza

spec/ParseFile.spec.js

@@ -655,31 +655,40 @@ describe('Parse.File testing', () => {
   });
 
   describe('getting files', () => {
-    it('can get invalid file', async () => {
-      const getFile = async () => {
-        try {
-          await request({ url: 'http://localhost:8378/1/files/invalid-id/invalid-file.txt' });
-        } catch (e) {
-          throw new Parse.Error(e.data.code, e.data.error);
-        }
-      };
-      await expectAsync(getFile()).toBeRejectedWith(
-        new Parse.Error(Parse.Error.OPERATION_FORBIDDEN, 'Invalid appId.')
-      );
-      const { status, data } = await request({ url: 'http://localhost:8378/1/health' });
-      expect(status).toEqual(200);
-      expect(data).toEqual({ status: 'ok' });
+    it('does not crash on file request with invalid app ID', async () => {
+      const res1 = await request({
+        url: 'http://localhost:8378/1/files/invalid-id/invalid-file.txt',
+      }).catch(e => e);
+      expect(res1.status).toBe(403);
+      expect(res1.data).toEqual({ code: 119, error: 'Invalid application ID.' });
+      // Ensure server did not crash
+      const res2 = await request({ url: 'http://localhost:8378/1/health' });
+      expect(res2.status).toEqual(200);
+      expect(res2.data).toEqual({ status: 'ok' });
+    });
+
+    it('does not crash on file request with invalid path', async () => {
+      const res1 = await request({
+        url: 'http://localhost:8378/1/files/invalid-id//invalid-path/%20/invalid-file.txt',
+      }).catch(e => e);
+      expect(res1.status).toBe(403);
+      expect(res1.data).toEqual({ error: 'unauthorized' });
+      // Ensure server did not crash
+      const res2 = await request({ url: 'http://localhost:8378/1/health' });
+      expect(res2.status).toEqual(200);
+      expect(res2.data).toEqual({ status: 'ok' });
     });
 
-    it('can get invalid metadata', async () => {
-      const metadata = await request({
+    it('does not crash on file metadata request with invalid app ID', async () => {
+      const res1 = await request({
         url: `http://localhost:8378/1/files/invalid-id/metadata/invalid-file.txt`,
       });
-      expect(metadata.status).toBe(200);
-      expect(metadata.data).toEqual({});
-      const { status, data } = await request({ url: 'http://localhost:8378/1/health' });
-      expect(status).toEqual(200);
-      expect(data).toEqual({ status: 'ok' });
+      expect(res1.status).toBe(200);
+      expect(res1.data).toEqual({});
+      // Ensure server did not crash
+      const res2 = await request({ url: 'http://localhost:8378/1/health' });
+      expect(res2.status).toEqual(200);
+      expect(res2.data).toEqual({ status: 'ok' });
     });
   });