Skip to content

Commit 12df37f

Browse files
MoumoulsMoumouls
committed
test: update node 18
1 parent 13b2034 commit 12df37f

File tree

2 files changed

+55
-62
lines changed

2 files changed

+55
-62
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 55 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: ci
22
on:
33
push:
4-
branches: [ release, alpha, beta, next-major, 'release-[0-9]+.x.x' ]
4+
branches: [release, alpha, beta, next-major, 'release-[0-9]+.x.x']
55
pull_request:
66
branches:
77
- '**'
@@ -21,17 +21,17 @@ jobs:
2121
strategy:
2222
fail-fast: false
2323
matrix:
24-
language: [ 'javascript' ]
24+
language: ['javascript']
2525
steps:
26-
- name: Checkout repository
27-
uses: actions/checkout@v3
28-
- name: Initialize CodeQL
29-
uses: github/codeql-action/init@v2
30-
with:
31-
languages: ${{ matrix.language }}
32-
source-root: src
33-
- name: Perform CodeQL Analysis
34-
uses: github/codeql-action/analyze@v2
26+
- name: Checkout repository
27+
uses: actions/checkout@v3
28+
- name: Initialize CodeQL
29+
uses: github/codeql-action/init@v2
30+
with:
31+
languages: ${{ matrix.language }}
32+
source-root: src
33+
- name: Perform CodeQL Analysis
34+
uses: github/codeql-action/analyze@v2
3535
check-ci:
3636
name: Node Engine Check
3737
timeout-minutes: 15
@@ -54,30 +54,30 @@ jobs:
5454
- name: CI Node Engine Check
5555
run: npm run ci:checkNodeEngine
5656
check-lint:
57-
name: Lint
58-
timeout-minutes: 15
59-
runs-on: ubuntu-latest
60-
steps:
61-
- uses: actions/checkout@v2
62-
- name: Use Node.js ${{ matrix.NODE_VERSION }}
63-
uses: actions/setup-node@v2
64-
with:
65-
node-version: ${{ matrix.node-version }}
66-
- name: Cache Node.js modules
67-
uses: actions/cache@v2
68-
with:
69-
path: ~/.npm
70-
key: ${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-${{ hashFiles('**/package-lock.json') }}
71-
restore-keys: |
72-
${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-
73-
- name: Install dependencies
74-
run: npm ci
75-
- run: npm run lint
57+
name: Lint
58+
timeout-minutes: 15
59+
runs-on: ubuntu-latest
60+
steps:
61+
- uses: actions/checkout@v2
62+
- name: Use Node.js ${{ matrix.NODE_VERSION }}
63+
uses: actions/setup-node@v2
64+
with:
65+
node-version: ${{ matrix.node-version }}
66+
- name: Cache Node.js modules
67+
uses: actions/cache@v2
68+
with:
69+
path: ~/.npm
70+
key: ${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-${{ hashFiles('**/package-lock.json') }}
71+
restore-keys: |
72+
${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-
73+
- name: Install dependencies
74+
run: npm ci
75+
- run: npm run lint
7676
check-definitions:
77-
name: Check Definitions
78-
timeout-minutes: 5
79-
runs-on: ubuntu-latest
80-
steps:
77+
name: Check Definitions
78+
timeout-minutes: 5
79+
runs-on: ubuntu-latest
80+
steps:
8181
- uses: actions/checkout@v2
8282
- name: Use Node.js ${{ matrix.NODE_VERSION }}
8383
uses: actions/setup-node@v2
@@ -95,25 +95,25 @@ jobs:
9595
- name: CI Definitions Check
9696
run: npm run ci:definitionsCheck
9797
check-circular:
98-
name: Circular Dependencies
99-
timeout-minutes: 5
100-
runs-on: ubuntu-latest
101-
steps:
102-
- uses: actions/checkout@v2
103-
- name: Use Node.js ${{ matrix.NODE_VERSION }}
104-
uses: actions/setup-node@v2
105-
with:
106-
node-version: ${{ matrix.node-version }}
107-
- name: Cache Node.js modules
108-
uses: actions/cache@v2
109-
with:
110-
path: ~/.npm
111-
key: ${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-${{ hashFiles('**/package-lock.json') }}
112-
restore-keys: |
113-
${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-
114-
- name: Install dependencies
115-
run: npm ci
116-
- run: npm run madge:circular
98+
name: Circular Dependencies
99+
timeout-minutes: 5
100+
runs-on: ubuntu-latest
101+
steps:
102+
- uses: actions/checkout@v2
103+
- name: Use Node.js ${{ matrix.NODE_VERSION }}
104+
uses: actions/setup-node@v2
105+
with:
106+
node-version: ${{ matrix.node-version }}
107+
- name: Cache Node.js modules
108+
uses: actions/cache@v2
109+
with:
110+
path: ~/.npm
111+
key: ${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-${{ hashFiles('**/package-lock.json') }}
112+
restore-keys: |
113+
${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-
114+
- name: Install dependencies
115+
run: npm ci
116+
- run: npm run madge:circular
117117
check-docker:
118118
name: Docker Build
119119
timeout-minutes: 15
@@ -177,7 +177,7 @@ jobs:
177177
- name: Node 18
178178
MONGODB_VERSION: 4.4.13
179179
MONGODB_TOPOLOGY: standalone
180-
NODE_VERSION: 18.12.1
180+
NODE_VERSION: 18.18.2
181181
fail-fast: false
182182
name: ${{ matrix.name }}
183183
timeout-minutes: 15
@@ -186,7 +186,7 @@ jobs:
186186
redis:
187187
image: redis
188188
ports:
189-
- 6379:6379
189+
- 6379:6379
190190
env:
191191
MONGODB_VERSION: ${{ matrix.MONGODB_VERSION }}
192192
MONGODB_TOPOLOGY: ${{ matrix.MONGODB_TOPOLOGY }}

‎spec/ParseGraphQLServer.spec.js‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
const http = require('http');
2-
const { Agent } = require('http');
32
const express = require('express');
43
const req = require('../lib/request');
54
const fetch = (...args) => import('node-fetch').then(({ default: fetch }) => fetch(...args));
@@ -45,8 +44,6 @@ function handleError(e) {
4544
}
4645
}
4746

48-
const testAgentWithoutKeepAlive = new Agent();
49-
5047
describe('ParseGraphQLServer', () => {
5148
let parseServer;
5249
let parseGraphQLServer;
@@ -6878,7 +6875,6 @@ describe('ParseGraphQLServer', () => {
68786875
method: 'POST',
68796876
headers,
68806877
body,
6881-
agent: testAgentWithoutKeepAlive,
68826878
});
68836879

68846880
expect(res.status).toEqual(200);
@@ -9342,7 +9338,6 @@ describe('ParseGraphQLServer', () => {
93429338
method: 'POST',
93439339
headers,
93449340
body,
9345-
agent: testAgentWithoutKeepAlive,
93469341
});
93479342

93489343
expect(res.status).toEqual(200);
@@ -9591,7 +9586,6 @@ describe('ParseGraphQLServer', () => {
95919586
method: 'POST',
95929587
headers,
95939588
body,
9594-
agent: testAgentWithoutKeepAlive,
95959589
});
95969590

95979591
expect(res.status).toEqual(200);
@@ -9645,7 +9639,6 @@ describe('ParseGraphQLServer', () => {
96459639
method: 'POST',
96469640
headers,
96479641
body,
9648-
agent: testAgentWithoutKeepAlive,
96499642
});
96509643

96519644
const result = JSON.parse(await res.text());

0 commit comments

Comments
 (0)