fix: use last index of period to determine extension

Marc Derhammer · Marc Derhammer · commit 09008bf0f1a5 · 2023-09-19T13:17:07.000-04:00
related to #8753
diff --git a/spec/ParseFile.spec.js b/spec/ParseFile.spec.js
@@ -1364,6 +1364,30 @@ describe('Parse.File testing', () => {
       );
     });
 
+    it('works with a period in the file name', async () => {
+      await reconfigureServer({
+        fileUpload: {
+          enableForPublic: true,
+        },
+      });
+      const headers = {
+        'X-Parse-Application-Id': 'test',
+        'X-Parse-REST-API-Key': 'rest',
+      };
+      await expectAsync(
+        request({
+          method: 'POST',
+          headers: headers,
+          url: 'http://localhost:8378/1/files/file.png.html',
+          body: '<html></html>\n',
+        }).catch(e => {
+          throw new Error(e.data.error);
+        })
+      ).toBeRejectedWith(
+        new Parse.Error(Parse.Error.FILE_SAVE_ERROR, `File upload of extension html is disabled.`)
+      );
+    });
+
     it('works with array', async () => {
       await reconfigureServer({
         fileUpload: {
diff --git a/src/Routers/FilesRouter.js b/src/Routers/FilesRouter.js
@@ -155,7 +155,7 @@ export class FilesRouter {
       };
       let extension = contentType;
       if (filename && filename.includes('.')) {
-        extension = filename.split('.')[1];
+        extension = filename.split('.')[filename.split('.').length - 1];
       } else if (contentType && contentType.includes('/')) {
         extension = contentType.split('/')[1];
       }

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ export class FilesRouter {`
`155`	`155`	`};`
`156`	`156`	`let extension = contentType;`
`157`	`157`	`if (filename && filename.includes('.')) {`
`158`		`- extension = filename.split('.')[1];`
	`158`	`+ extension = filename.split('.')[filename.split('.').length - 1];`
`159`	`159`	`} else if (contentType && contentType.includes('/')) {`
`160`	`160`	`extension = contentType.split('/')[1];`
`161`	`161`	`}`