Skip to content

APNS expects expiration time to be in seconds, not MS. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2016
Merged

APNS expects expiration time to be in seconds, not MS. #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/APNS.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('APNS', () => {
'key': 'value',
'keyAgain': 'valueAgain'
});
expect(notification.expiry).toEqual(expirationTime);
expect(notification.expiry).toEqual(expirationTime/1000);
done();
});

Expand Down Expand Up @@ -298,7 +298,7 @@ describe('APNS', () => {
var args = conn.pushNotification.calls.first().args;
var notification = args[0];
expect(notification.alert).toEqual(data.data.alert);
expect(notification.expiry).toEqual(data['expiration_time']);
expect(notification.expiry).toEqual(data['expiration_time']/1000);
var apnDevice = args[1]
expect(apnDevice.connIndex).toEqual(0);
expect(apnDevice.appIdentifier).toEqual('bundleId');
Expand Down
3 changes: 2 additions & 1 deletion src/APNS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ function chooseConns(conns, device) {
/**
* Generate the apns notification from the data we get from api request.
* @param {Object} coreData The data field under api request body
* @param {number} expirationTime The expiration time in milliseconds since Jan 1 1970
* @returns {Object} A apns notification
*/
function generateNotification(coreData, expirationTime) {
Expand Down Expand Up @@ -231,7 +232,7 @@ function generateNotification(coreData, expirationTime) {
}
}
notification.payload = payload;
notification.expiry = expirationTime;
notification.expiry = expirationTime / 1000;
return notification;
}

Expand Down