Push Audiences improvements #813
Conversation
flovilmart
commented
Nov 18, 2017
flovilmart
commented
- Fix issue affecting bad requests with audience_limit
- Adds support for sizing audiences in the dashboard running counts on _Installation table
| urlsSeparator = '&'; | ||
| let promise; | ||
| if (!query) { | ||
| promise = new Parse.Query('_Audience').get(audienceId, { useMasterKey: true }).then(function(audience) { |
There was a problem hiding this comment.
we may wanna add caching for those counts as may be quite expensive on the DB.
There was a problem hiding this comment.
@flovilmart do we want to add in caching with this PR or do we want to handle this later on?
There was a problem hiding this comment.
Also if this runs okay on your end this would be great to get in. About time we should put up a dashboard release so we can get past #811 .
There was a problem hiding this comment.
Yep, caching would need more work, not required
There was a problem hiding this comment.
Ehhh, maybe in this case we should cache. Although we could take it as is it would be nice to not have to come back and do that later.
|
@montymxb i’d Like to get this one in for the release too |
|
Yep yep, just saw this. Sorry I'm behind by a day or so and just going through everything. |
* parse: Update dependencies to enable Greenkeeper 🌴 (parse-community#865) Ensure we traverse the payloadJSON properly (parse-community#861) Push Audiences improvements (parse-community#813)
