Skip to content

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented Jan 20, 2023

New Pull Request Checklist

Issue Description

Parse Dashboard currently displays a white screen if the server is unreachable, without showing any useful information. This PR changes this to:

Screenshot 2023-01-20 at 3 23 25 pm

Parse Dashboard also allows routing to unsupported legacy routes (by manually entering the URL), such as:

Screenshot 2023-01-20 at 3 22 02 pm

This PR adds a check to make sure the route is supported, and if not:

Screenshot 2023-01-20 at 3 23 53 pm

Closes: #1596

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 20, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy dblythy requested a review from a team January 20, 2023 04:36
@mtrezza mtrezza changed the title fix: dashboard displays white screen if server is unreachable, dashboard can route to unsupported routes fix: Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs Jan 20, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 9855258 into parse-community:alpha Jan 20, 2023
parseplatformorg pushed a commit that referenced this pull request Jan 20, 2023
# [5.1.0-alpha.2](5.1.0-alpha.1...5.1.0-alpha.2) (2023-01-20)

### Bug Fixes

* Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 20, 2023
@dblythy dblythy deleted the white-screen branch January 20, 2023 20:00
@mtrezza mtrezza mentioned this pull request Jan 27, 2023
3 tasks
parseplatformorg pushed a commit that referenced this pull request Mar 1, 2023
# [5.1.0-beta.2](5.1.0-beta.1...5.1.0-beta.2) (2023-03-01)

### Bug Fixes

* Add dashboard option `cookieSessionMaxAge` to keep user logged in across browser sessions ([#2366](#2366)) ([9ea95fc](9ea95fc))
* Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258))
* Dashboard may display blank page when selecting an app after login ([#2375](#2375)) ([f399b91](f399b91))
* Data browser dialog "No data to display" may be outside of visible area in Safari browser ([#2387](#2387)) ([52bba62](52bba62))
* Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f))
* Navigation to page fails if user re-login is required ([#2369](#2369)) ([0db6f55](0db6f55))
* Screen goes blank when trying to add column of type `Object` or `GeoPoint` ([#2384](#2384)) ([0886386](0886386))
* Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c))

### Features

* Add export all rows of a class and export in JSON format ([#2361](#2361)) ([9eb36a1](9eb36a1))
* Add schema export ([#2362](#2362)) ([33df049](33df049))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 1, 2023
parseplatformorg pushed a commit that referenced this pull request May 1, 2023
# [5.1.0](5.0.0...5.1.0) (2023-05-01)

### Bug Fixes

* Add dashboard option `cookieSessionMaxAge` to keep user logged in across browser sessions ([#2366](#2366)) ([9ea95fc](9ea95fc))
* Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258))
* Dashboard may display blank page when selecting an app after login ([#2375](#2375)) ([f399b91](f399b91))
* Data browser dialog "No data to display" may be outside of visible area in Safari browser ([#2387](#2387)) ([52bba62](52bba62))
* Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f))
* Navigation to page fails if user re-login is required ([#2369](#2369)) ([0db6f55](0db6f55))
* Screen goes blank when trying to add column of type `Object` or `GeoPoint` ([#2384](#2384)) ([0886386](0886386))
* Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c))

### Features

* Add export all rows of a class and export in JSON format ([#2361](#2361)) ([9eb36a1](9eb36a1))
* Add schema export ([#2362](#2362)) ([33df049](33df049))
* remove limitation to refresh Cloud Jobs list only after 30 seconds ([#2332](#2332)) ([ad1132f](ad1132f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse Dashboard only showing a blank white page

3 participants