From 61d342d70cdfd4b8ec8172e1b3853beccccf58b9 Mon Sep 17 00:00:00 2001 From: sadakchap Date: Fri, 28 May 2021 11:47:32 +0530 Subject: [PATCH 1/2] validating column name --- src/dashboard/Data/Browser/AddColumnDialog.react.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dashboard/Data/Browser/AddColumnDialog.react.js b/src/dashboard/Data/Browser/AddColumnDialog.react.js index bf1cf6c33d..9bed765cce 100644 --- a/src/dashboard/Data/Browser/AddColumnDialog.react.js +++ b/src/dashboard/Data/Browser/AddColumnDialog.react.js @@ -27,7 +27,7 @@ import { } from 'lib/Constants'; function validColumnName(name) { - return !!name.match(/^[a-zA-Z0-9][_a-zA-Z0-9]*$/); + return !!name.match(/^[a-zA-Z][_a-zA-Z0-9]*$/); } export default class AddColumnDialog extends React.Component { From b5d7c91049ecf0ea99513fa44b05de087707ed3b Mon Sep 17 00:00:00 2001 From: sadakchap Date: Mon, 31 May 2021 23:47:53 +0530 Subject: [PATCH 2/2] showing error note on fail add column op --- src/dashboard/Data/Browser/Browser.react.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/dashboard/Data/Browser/Browser.react.js b/src/dashboard/Data/Browser/Browser.react.js index 85043c01cd..27d3afffc8 100644 --- a/src/dashboard/Data/Browser/Browser.react.js +++ b/src/dashboard/Data/Browser/Browser.react.js @@ -280,7 +280,9 @@ class Browser extends DashboardView { required, defaultValue }; - this.props.schema.dispatch(ActionTypes.ADD_COLUMN, payload).finally(() => { + this.props.schema.dispatch(ActionTypes.ADD_COLUMN, payload).catch((err) => { + this.showNote(err.message, true); + }).finally(() => { this.setState({ showAddColumnDialog: false }); }); }