fix: Can't access method 'hasOwnProperty' from target object (#1172)

Author: alencarlucas

package-lock.json

@@ -65,7 +65,7 @@ let BrowserCell = ({ type, value, hidden, width, current, onSelect, onEditChange
   } else if (type === 'ACL') {
     let pieces = [];
     let json = value.toJSON();
-    if (json.hasOwnProperty('*')) {
+    if (Object.prototype.hasOwnProperty.call(json, '*')) {
       if (json['*'].read && json['*'].write) {
         pieces.push('Public Read + Write');
       } else if (json['*'].read) {

src/components/BrowserCell/BrowserCell.react.js

@@ -370,7 +370,7 @@ export default class ExplorerQueryComposer extends React.Component {
   }
 
   renderFilter(filter, index=0) {
-    let type = Constraints[filter.op].hasOwnProperty('field') ? Constraints[filter.op].field : FIELD_TYPE[filter.col];
+    let type = Object.prototype.hasOwnProperty.call(Constraints[filter.op], 'field') ? Constraints[filter.op].field : FIELD_TYPE[filter.col];
 
     let constraintView = null;
     if (type === 'JSON') {

src/components/ExplorerQueryComposer/ExplorerQueryComposer.react.js

@@ -22,7 +22,7 @@ function changeField(schema, filters, index, newField) {
 function changeConstraint(schema, filters, index, newConstraint) {
   let field = filters.get(index).get('field');
   let compareType = schema[field].type;
-  if (Filters.Constraints[newConstraint].hasOwnProperty('field')) {
+  if (Object.prototype.hasOwnProperty.call(Filters.Constraints[newConstraint], 'field')) {
     compareType = Filters.Constraints[newConstraint].field;
   }
   let newFilter = new Map({
@@ -59,7 +59,7 @@ let Filter = ({ schema, filters, renderRow, onChange, blacklist }) => {
         fields.sort();
         let constraints = Filters.FieldConstraints[schema[field].type].filter((c) => blacklist.indexOf(c) < 0);
         let compareType = schema[field].type;
-        if (Filters.Constraints[constraint].hasOwnProperty('field')) {
+        if (Object.prototype.hasOwnProperty.call(Filters.Constraints[constraint], 'field')) {
           compareType = Filters.Constraints[constraint].field;
         }
         return renderRow({

src/components/Filter/Filter.react.js

@@ -32,7 +32,7 @@ const AUDIENCE_SIZE_FETCHING_ENABLED = true;
 let filterFormatter = (filters, schema) => {
   return filters.map((filter) => {
     let type = schema[filter.get('field')];
-    if (Filters.Constraints[filter.get('constraint')].hasOwnProperty('field')) {
+    if (Object.prototype.hasOwnProperty.call(Filters.Constraints[filter.get('constraint')], 'field')) {
       type = Filters.Constraints[filter.get('constraint')].field;
     }
     // Format any stringified fields

src/components/PushAudienceDialog/PushAudienceDialog.react.js

@@ -129,7 +129,7 @@ class SlowQueries extends TableView {
         let os = value['OS'];
         let version = value['App Display Version'];
         if (os === null || version === null) return;
-        if (appVersions.hasOwnProperty(os)) {
+        if (Object.prototype.hasOwnProperty.call(appVersions, os)) {
           appVersions[os].push(version);
         } else {
           appVersions[os] = [version];

src/dashboard/Analytics/SlowQueries/SlowQueries.react.js

@@ -98,7 +98,7 @@ let isChannelTargeted = (pushData) => {
   let additionalKeys = false;
 
   for (let key in queryJSON) {
-    if (queryJSON.hasOwnProperty(key)) {
+    if (Object.prototype.hasOwnProperty.call(queryJSON, key)) {
       if (key !== 'deviceType' && key !== 'channels') {
         additionalKeys = true;
       }

src/dashboard/Push/PushIndex.react.js

@@ -59,7 +59,7 @@ export function request(method, url, body, abortable = false, withCredentials =
         p.reject(this.responseText);
         return;
       }
-      if (json.hasOwnProperty('success') && json.success === false) {
+      if (Object.prototype.hasOwnProperty.call(json, 'success') && json.success === false) {
         p.reject(json);
       } else {
         p.resolve(json);

src/lib/AJAX.js

@@ -159,7 +159,7 @@ let formatConstraintComponent = (key, operation, value, schema) => {
 let formatStructure = (key, constraints, schema) => {
   let rows = [];
   for(let prop in constraints){
-    if(constraints.hasOwnProperty(prop)){
+    if(Object.prototype.hasOwnProperty.call(constraints, prop)){
       rows.push(formatConstraintComponent(key, prop, constraints[prop], schema));
     }
   }
@@ -287,9 +287,9 @@ export function largeInfoBuilder(query, schema, styles = {}) {
         <ul className={styles.installationInfo}>
           <li className={styles.detailsHeaderListItem}>INSTALLATION CONDITIONS</li>
           {conditionRows}
-        </ul> : 
+        </ul> :
         null
-      }    
+      }
     </div>
   )
 }
@@ -307,7 +307,7 @@ let tableInfoBuilderHelper = (styles, key, description, value) => {
 export function tableInfoBuilder(query, schema, styles = {}) {
   try {
     query = JSON.parse(query);
-  } catch(e) {/**/} 
+  } catch(e) {/**/}
 
   if(!query) {
     return;