fix: Null fix in ParseObject (#2622)

Author: Marcus Olsson

src/ParseObject.ts

@@ -514,8 +514,8 @@ class ParseObject<T extends Attributes = Attributes> {
 
   static _getRequestOptions(options: RequestOptions & FullOptions & { json?: boolean } = {}) {
     const requestOptions: RequestOptions & FullOptions & { json?: boolean } = {};
-    if (!options) {
-      return requestOptions;
+    if (Object.prototype.toString.call(options) !== '[object Object]') {
+      throw new Error('request options must be of type Object');
     }
     const { hasOwn } = Object;
     if (hasOwn(options, 'useMasterKey')) {

src/__tests__/Cloud-test.js

@@ -356,4 +356,31 @@ describe('CloudController', () => {
     });
     expect(options.useMasterKey).toBe(false);
   });
+    
+  it('run passes with empty options', () => {
+    const values = [undefined, {}];
+
+    const mockRun = jest.fn();
+    mockRun.mockReturnValue(Promise.resolve({ result: {} }));
+
+    CoreManager.setCloudController({
+      run: mockRun,
+      getJobsData: jest.fn(),
+      startJob: jest.fn(),
+    });
+
+    for (const value of values) {
+      mockRun.mockClear();
+      expect(() => Cloud.run('myfunction', {}, value)).not.toThrow();
+      expect(mockRun).toHaveBeenLastCalledWith('myfunction', {}, {});
+    }
+  });
+
+  it('run throws with invalid options', () => {
+    const values = [null, []];
+    for (const value of values) {
+      expect(() => Cloud.run('myfunction', {}, value)).toThrow();
+    }
+  });
+    
 });

src/__tests__/ParseObject-test.js

@@ -3543,23 +3543,3 @@ describe('ParseObject pin', () => {
     CoreManager.set('NODE_LOGGING', false);
   });
 });
-
-describe('ParseObject._getRequestOptions', () => {
-  it('returns empty object when options is null', () => {
-    const requestOptions = ParseObject._getRequestOptions(null);
-
-    expect(requestOptions).toEqual({});
-  });
-
-  it('returns empty object when options is an empty string', () => {
-    const requestOptions = ParseObject._getRequestOptions("");
-
-    expect(requestOptions).toEqual({});
-  });
-
-  it('returns empty object when options is undefined', () => {
-    const requestOptions = ParseObject._getRequestOptions(undefined);
-
-    expect(requestOptions).toEqual({});
-  });
-});