Add support for Android O (#713)

* Add Notification Channels configuration for Android O

* Revert build tools version

* Update travis.yml to android-26

* Switch to making a notification channel instead based on feedback

* Add comment on recreating notification channels

* Only call getNotificationChannel on SDK >= 26

* Extract createNotificationChannel to own method and call it from getNotification

* Update to build-tools 26.0.1

* Save channelId instead of whole channel in NotificationCompat

* Update robolectric to support API 26

* Downgrade to robolectric 3.3.2

Author: iernie

.travis.yml

@@ -13,9 +13,9 @@ android:
   components:
     - tools
     - platform-tools
-    - build-tools-25.0.3
-    - android-25
-    - doc-25
+    - build-tools-26.0.1
+    - android-26
+    - doc-26
 
 before_install:
     - pip install --user codecov

Parse/build.gradle

@@ -59,11 +59,7 @@ dependencies {
     compile 'com.parse.bolts:bolts-tasks:1.4.0'
     compile "com.squareup.okhttp3:okhttp:$okhttpVersion"
 
-    //Be aware, tests fail on 3.3.2 Wait to update until
-    //java.lang.NoClassDefFoundError: android/content/pm/VersionedPackage
-    //issue is fixed in Robolectric
-    //https://github.com/robolectric/robolectric/issues/2562
-    testCompile 'org.robolectric:robolectric:3.3'
+    testCompile 'org.robolectric:robolectric:3.3.2'
     testCompile 'org.skyscreamer:jsonassert:1.5.0'
     testCompile 'org.mockito:mockito-core:1.10.19'
     testCompile "com.squareup.okhttp3:mockwebserver:$okhttpVersion"

Parse/src/main/java/com/parse/NotificationCompat.java

@@ -18,6 +18,7 @@
 
 import android.annotation.TargetApi;
 import android.app.Notification;
+import android.app.NotificationChannel;
 import android.app.NotificationManager;
 import android.app.PendingIntent;
 import android.content.Context;
@@ -95,6 +96,9 @@ public Notification build(Builder b) {
           }
         }
       }
+      if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+        postJellyBeanBuilder.setChannelId(b.mNotificationChannelId);
+      }
       return postJellyBeanBuilder.build();
     }
   }
@@ -124,6 +128,7 @@ public static class Builder {
     Bitmap mLargeIcon;
     int mPriority;
     Style mStyle;
+    String mNotificationChannelId;
 
     Notification mNotification = new Notification();
 
@@ -188,6 +193,14 @@ public Builder setContentTitle(CharSequence title) {
       return this;
     }
 
+    /**
+     * Set the notification channel of the notification, in a standard notification.
+     */
+    public Builder setNotificationChannel(String notificationChannelId) {
+      mNotificationChannelId = notificationChannelId;
+      return this;
+    }
+
     /**
      * Set the text (second row) of the notification, in a standard notification.
      */

Parse/src/main/java/com/parse/ParseNotificationManager.java

@@ -12,6 +12,7 @@
 
 import android.app.Activity;
 import android.app.Notification;
+import android.app.NotificationChannel;
 import android.app.NotificationManager;
 import android.app.PendingIntent;
 import android.content.ComponentName;
@@ -20,6 +21,7 @@
 import android.content.res.Resources;
 import android.content.res.Resources.NotFoundException;
 import android.graphics.drawable.Drawable;
+import android.os.Build;
 import android.os.Bundle;
 import android.util.SparseIntArray;
 

Parse/src/main/java/com/parse/ParsePushBroadcastReceiver.java

@@ -8,8 +8,11 @@
  */
 package com.parse;
 
+import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.Notification;
+import android.app.NotificationChannel;
+import android.app.NotificationManager;
 import android.app.PendingIntent;
 import android.content.BroadcastReceiver;
 import android.content.Context;
@@ -260,6 +263,37 @@ protected Class<? extends Activity> getActivity(Context context, Intent intent)
     return cls;
   }
 
+  /**
+   * Retrieves the channel to be used in a {@link Notification} if API >= 26, if not null. The default returns a new channel
+   * with id "parse_push", name "Push notifications" and default importance.
+   *
+   * @param context
+   *      The {@code Context} in which the receiver is running.
+   * @param intent
+   *      An {@code Intent} containing the channel and data of the current push notification.
+   * @return
+   *      The notification channel
+   */
+  @TargetApi(Build.VERSION_CODES.O)
+  protected NotificationChannel getNotificationChannel(Context context, Intent intent) {
+    return new NotificationChannel("parse_push", "Push notifications", NotificationManager.IMPORTANCE_DEFAULT);
+  }
+
+  /**
+   * Creates the notification channel with the NotificationManager. Channel is not recreated
+   * if the channel properties are unchanged.
+   *
+   * @param context
+   *      The {@code Context} in which the receiver is running.
+   * @param notificationChannel
+   *      The {@code NotificationChannel} to be created.
+   */
+  @TargetApi(Build.VERSION_CODES.O)
+  protected void createNotificationChannel(Context context, NotificationChannel notificationChannel) {
+    NotificationManager nm = (NotificationManager) context.getSystemService(Context.NOTIFICATION_SERVICE);
+    nm.createNotificationChannel(notificationChannel);
+  }
+
   /**
    * Retrieves the small icon to be used in a {@link Notification}. The default implementation uses
    * the icon specified by {@code com.parse.push.notification_icon} {@code meta-data} in your
@@ -364,6 +398,8 @@ protected Notification getNotification(Context context, Intent intent) {
     PendingIntent pDeleteIntent = PendingIntent.getBroadcast(context, deleteIntentRequestCode,
         deleteIntent, PendingIntent.FLAG_UPDATE_CURRENT);
 
+
+
     // The purpose of setDefaults(Notification.DEFAULT_ALL) is to inherit notification properties
     // from system defaults
     NotificationCompat.Builder parseBuilder = new NotificationCompat.Builder(context);
@@ -376,6 +412,13 @@ protected Notification getNotification(Context context, Intent intent) {
         .setDeleteIntent(pDeleteIntent)
         .setAutoCancel(true)
         .setDefaults(Notification.DEFAULT_ALL);
+
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+      NotificationChannel notificationChannel = getNotificationChannel(context, intent);
+      createNotificationChannel(context, notificationChannel);
+      parseBuilder.setNotificationChannel(notificationChannel.getId());
+    }
+
     if (alert != null
         && alert.length() > ParsePushBroadcastReceiver.SMALL_NOTIFICATION_MAX_CHARACTER_LIMIT) {
       parseBuilder.setStyle(new NotificationCompat.Builder.BigTextStyle().bigText(alert));

Parse/src/test/java/com/parse/ParseClientConfigurationTest.java

@@ -27,7 +27,7 @@
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(constants = BuildConfig.class)
+@Config(constants = BuildConfig.class, sdk = TestHelper.ROBOLECTRIC_SDK_VERSION)
 public class ParseClientConfigurationTest {
 
   private final String serverUrl = "http://example.com/parse";

build.gradle

@@ -4,7 +4,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:2.3.2'
+        classpath 'com.android.tools.build:gradle:2.3.3'
     }
 }
 
@@ -22,11 +22,11 @@ allprojects {
 }
 
 ext {
-    compileSdkVersion = 25
-    buildToolsVersion = "25.0.3"
+    compileSdkVersion = 26
+    buildToolsVersion = "26.0.1"
 
     supportLibVersion = '25.3.1'
 
     minSdkVersion = 9
-    targetSdkVersion = 25
+    targetSdkVersion = 26
 }