Use AsyncReadExt::read_exact, not just read (#6977)

tomaka · bkchr · commit 7d53c94d57c7 · 2020-09-18T21:42:45.000+02:00
diff --git a/client/network/src/protocol/generic_proto/upgrade/notifications.rs b/client/network/src/protocol/generic_proto/upgrade/notifications.rs
@@ -148,7 +148,7 @@ where TSubstream: AsyncRead + AsyncWrite + Unpin + Send + 'static,
 
 			let mut initial_message = vec![0u8; initial_message_len];
 			if !initial_message.is_empty() {
-				socket.read(&mut initial_message).await?;
+				socket.read_exact(&mut initial_message).await?;
 			}
 
 			let substream = NotificationsInSubstream {
@@ -300,7 +300,7 @@ where TSubstream: AsyncRead + AsyncWrite + Unpin + Send + 'static,
 
 			let mut handshake = vec![0u8; handshake_len];
 			if !handshake.is_empty() {
-				socket.read(&mut handshake).await?;
+				socket.read_exact(&mut handshake).await?;
 			}
 
 			Ok((handshake, NotificationsOutSubstream {

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ where TSubstream: AsyncRead + AsyncWrite + Unpin + Send + 'static,`
`148`	`148`
`149`	`149`	`let mut initial_message = vec![0u8; initial_message_len];`
`150`	`150`	`if !initial_message.is_empty() {`
`151`		`- socket.read(&mut initial_message).await?;`
	`151`	`+ socket.read_exact(&mut initial_message).await?;`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`let substream = NotificationsInSubstream {`
`@@ -300,7 +300,7 @@ where TSubstream: AsyncRead + AsyncWrite + Unpin + Send + 'static,`
`300`	`300`
`301`	`301`	`let mut handshake = vec![0u8; handshake_len];`
`302`	`302`	`if !handshake.is_empty() {`
`303`		`- socket.read(&mut handshake).await?;`
	`303`	`+ socket.read_exact(&mut handshake).await?;`
`304`	`304`	`}`
`305`	`305`
`306`	`306`	`Ok((handshake, NotificationsOutSubstream {`