Remove a max supply record on collection's destruction (#11593) (#11635)

* Remove a max supply record on collection's destruction

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/utility/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Co-authored-by: Parity Bot <[email protected]>

Co-authored-by: Jegor Sidorenko <[email protected]>
Co-authored-by: Parity Bot <[email protected]>

Author: 3 people

frame/uniques/src/functions.rs

@@ -115,6 +115,7 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
 			Attribute::<T, I>::remove_prefix((&collection,), None);
 			CollectionAccount::<T, I>::remove(&collection_details.owner, &collection);
 			T::Currency::unreserve(&collection_details.owner, collection_details.total_deposit);
+			CollectionMaxSupply::<T, I>::remove(&collection);
 
 			Self::deposit_event(Event::Destroyed { collection });
 

frame/uniques/src/tests.rs

@@ -684,5 +684,13 @@ fn max_supply_should_work() {
 			Uniques::mint(Origin::signed(user_id), collection_id, 2, user_id),
 			Error::<Test>::MaxSupplyReached
 		);
+
+		// validate we remove the CollectionMaxSupply record when we destroy the collection
+		assert_ok!(Uniques::destroy(
+			Origin::signed(user_id),
+			collection_id,
+			Collection::<Test>::get(collection_id).unwrap().destroy_witness()
+		));
+		assert!(!CollectionMaxSupply::<Test>::contains_key(collection_id));
 	});
 }