Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@alvicsam
Copy link
Contributor

Can I suggest using gitlab-ci instead of GHA?

Related to:
#614
#615

@alvicsam alvicsam requested review from a team, bkchr and chevdor September 16, 2021 09:13
@chevdor
Copy link
Contributor

chevdor commented Sep 16, 2021

What would be the benefit in this case ?

@alvicsam
Copy link
Contributor Author

What would be the benefit in this case ?

Almost all our projects use gitlab-ci and in future we want to have unified pipeline for all projects (at least the repeatable steps). So it's better to have one unified instrument for CI.

@alvicsam
Copy link
Contributor Author

Found out that paritytech/ci-linux doesn't have not fmt, nor clippy >_<
But I'll fix it.

@chevdor
Copy link
Contributor

chevdor commented Sep 16, 2021

For now, I am mainly working on fixing the issues related to those checks.

Whether we do the checks in github or gitlab can be discussed. I would prioritize simplicity and speed, this is why I went for GHA since this is supposed to be a quick check and not a big mechanics.

Ultimately, I don't mind but I find GHA more convenient for those, especially because we could have one Github Action that we use adn reused in most repos.

For big and heavy runs, I am with you on the choice of gitlab though.

NOTE: In your pipeline, you should run fmt first as it runs much faster and thus can fail much faster.

@alvicsam
Copy link
Contributor Author

fmt took 2 minutes, so it's relatively quick :) And it's just 5 lines in .giltab-ci.yml

NOTE: In your pipeline, you should run fmt first as it runs much faster and thus can fail much faster.

Currently they are in one stage, so they run simultaneously.

p.s. still need to add clippy to ci image

@rcny
Copy link
Contributor

rcny commented Sep 16, 2021

&kubernetes-env lacks image: "${CI_IMAGE}" directive.

@rcny rcny self-requested a review September 16, 2021 11:41
@bkchr
Copy link
Member

bkchr commented Sep 19, 2021

Already done. Ty anyway.

I know that this runs stuff on gitlab,but I don't see any advantage in this anyway, so I'm going to close this pr.

@bkchr bkchr closed this Sep 19, 2021
@bkchr bkchr deleted the as-add-ci-fmt-clippy branch September 19, 2021 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants