-
Notifications
You must be signed in to change notification settings - Fork 374
Add fmt and clippy #616
Add fmt and clippy #616
Conversation
|
What would be the benefit in this case ? |
Almost all our projects use gitlab-ci and in future we want to have unified pipeline for all projects (at least the repeatable steps). So it's better to have one unified instrument for CI. |
|
Found out that |
|
For now, I am mainly working on fixing the issues related to those checks. Whether we do the checks in github or gitlab can be discussed. I would prioritize simplicity and speed, this is why I went for GHA since this is supposed to be a quick check and not a big mechanics. Ultimately, I don't mind but I find GHA more convenient for those, especially because we could have one Github Action that we use adn reused in most repos. For big and heavy runs, I am with you on the choice of gitlab though. NOTE: In your pipeline, you should run |
|
Currently they are in one stage, so they run simultaneously. p.s. still need to add clippy to ci image |
|
|
|
Already done. Ty anyway. I know that this runs stuff on gitlab,but I don't see any advantage in this anyway, so I'm going to close this pr. |
Can I suggest using gitlab-ci instead of GHA?
Related to:
#614
#615