TYP: Persist typing information for pipe args and kwargs #56760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Still working on this, but sharing as an early draft for feedback and transparency. |
twoertwein
reviewed
Jan 7, 2024
twoertwein
reviewed
Jan 7, 2024
paw-lu
force-pushed
the
pipe-typing
branch
4 times, most recently
from
a3127c6 to
142d749
Compare
twoertwein
reviewed
Jan 8, 2024
twoertwein
reviewed
Jan 8, 2024
twoertwein
reviewed
Jan 9, 2024
paw-lu
force-pushed
the
pipe-typing
branch
3 times, most recently
from
a81c4de to
943fc3c
Compare
Dr-Irv
reviewed
Jan 12, 2024
twoertwein
approved these changes
Jan 13, 2024
Dr-Irv
approved these changes
Jan 15, 2024
Contributor
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
I'm fine with this. Will let others do the merge
Member
|
Thank you @paw-lu! |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…56760) * Type generic pipe with function params * Type common pipe with function params * Type resample pipe with function params * Type groupby pipe with function params * Type style pipe function params and tuple func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipewithParamSpec#56359doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Porting work done in:
argsandkwargsinpipepandas-stubs#823over to this repository.