assert_frame_equal for set #51899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

topper-123 merged 9 commits into pandas-dev:main from jayendra-patil33:assert_frame_equal_set

Mar 20, 2023

Contributor

jayendra-patil33 commented Mar 11, 2023 •

edited

Loading

closes BUG: assert_frame_equal failed on comparing two not equal Sets ('set' object is not subscriptable) #51727
[Tests added and passed]
All code checks passed.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

jayendra-patil33 added 3 commits

March 11, 2023 09:35


          Added check for sets in assert_almost_equal

9b5b640


          Added a message for assertion fail

46d28a8


          Added testcases for sets in test_assert_almost_equal.py and test_asse…

20f1585

…rt_almost_equal.py

topper-123 reviewed

View reviewed changes

pandas/tests/util/test_assert_almost_equal.py Show resolved Hide resolved

topper-123 reviewed

View reviewed changes

pandas/tests/util/test_assert_almost_equal.py Show resolved Hide resolved

topper-123 reviewed

View reviewed changes

pandas/tests/util/test_assert_frame_equal.py Show resolved Hide resolved

topper-123 reviewed

View reviewed changes

pandas/tests/util/test_assert_frame_equal.py Show resolved Hide resolved

topper-123 reviewed

View reviewed changes

Contributor

topper-123 left a comment

A few comments. Can you add line in whatsnew/v2.1.0.rst about this, under bug fixes/other.

mroeschke added the Testing label

jayendra-patil33 and others added 2 commits

March 18, 2023 08:40


          Added issue in whatsnew, issue number for tests

1e44b7e


          Merge branch 'pandas-dev:main' into assert_frame_equal_set

b4576eb

topper-123 reviewed

View reviewed changes

doc/source/whatsnew/v2.1.0.rst Outdated Show resolved Hide resolved

Contributor

topper-123 commented Mar 18, 2023

Ping when ready and I'll merge it.

jayendra-patil33 and others added 4 commits

March 18, 2023 19:44


          changed whatsnew

aaee432


          Merge branch 'pandas-dev:main' into assert_frame_equal_set

a97517e


          Merge remote-tracking branch 'pandas-jayendra/assert_frame_equal_set'…

dd82f97

… into assert_frame_equal_set

# Conflicts:
#	doc/source/whatsnew/v2.1.0.rst


          changed whatsnew

ea33c6d

Contributor Author

jayendra-patil33 commented Mar 18, 2023

@topper-123 done

topper-123 added this to the 2.1 milestone

topper-123 merged commit b5aec87 into pandas-dev:main

Contributor

topper-123 commented Mar 20, 2023

Thanks, @jayendra-patil33 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing