Skip to content

Conversation

@Yikun
Copy link
Contributor

@Yikun Yikun commented Apr 12, 2022

Add a test for pser.mode() should set series name

@Yikun Yikun changed the title TST: Add a test for pser.mode() should set series name TST: Add a test for pser.mode() should preserved series name Apr 12, 2022
@Yikun Yikun changed the title TST: Add a test for pser.mode() should preserved series name TST: Add a test for series name should be preserved in pser.mode() Apr 12, 2022
@jreback jreback added Testing pandas testing functions or related to the test suite Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff metadata _metadata, .attrs labels Apr 13, 2022
@Yikun
Copy link
Contributor Author

Yikun commented Apr 13, 2022

@mroeschke Done, thanks!

@mroeschke mroeschke added this to the 1.5 milestone Apr 13, 2022
@mroeschke mroeschke merged commit 0d07c23 into pandas-dev:main Apr 13, 2022
@mroeschke
Copy link
Member

Excellent, thanks @Yikun

(Failure unrelated)

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
…pandas-dev#46746)

* Add a test for Series.name preserved in ser.mode

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff metadata _metadata, .attrs Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: pser.mode() should not be set series name

3 participants