From a5a0a29dbb5e2ffb7af4cfe3c295fe00dceeed18 Mon Sep 17 00:00:00 2001 From: rxd330 Date: Fri, 18 Mar 2022 19:13:27 +0000 Subject: [PATCH 1/4] TST: tests added pre GH46313 --- pandas/tests/dtypes/test_dtypes.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pandas/tests/dtypes/test_dtypes.py b/pandas/tests/dtypes/test_dtypes.py index f077317e7ebbe..580d136505210 100644 --- a/pandas/tests/dtypes/test_dtypes.py +++ b/pandas/tests/dtypes/test_dtypes.py @@ -1107,3 +1107,15 @@ def test_compare_complex_dtypes(): with pytest.raises(TypeError, match=msg): df.lt(df.astype(object)) + + +def test_categorical_of_booleans_is_boolean(): + # https://github.com/pandas-dev/pandas/issues/46313 + df = pd.DataFrame( + {"int_cat": [1, 2, 3], "bool_cat": [True, False, False]}, dtype="category" + ) + value = df["bool_cat"].cat.categories.dtype + expected = np.dtype(np.bool_) + not_expected = np.dtype(np.object_) + assert value is expected + assert value is not not_expected From 55ca0e01443e3771c4df1c5c347740ac4d414cef Mon Sep 17 00:00:00 2001 From: rxd330 Date: Fri, 18 Mar 2022 19:34:01 +0000 Subject: [PATCH 2/4] Revert "TST: tests added pre GH46313" This reverts commit a5a0a29dbb5e2ffb7af4cfe3c295fe00dceeed18. --- pandas/tests/dtypes/test_dtypes.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/pandas/tests/dtypes/test_dtypes.py b/pandas/tests/dtypes/test_dtypes.py index 580d136505210..f077317e7ebbe 100644 --- a/pandas/tests/dtypes/test_dtypes.py +++ b/pandas/tests/dtypes/test_dtypes.py @@ -1107,15 +1107,3 @@ def test_compare_complex_dtypes(): with pytest.raises(TypeError, match=msg): df.lt(df.astype(object)) - - -def test_categorical_of_booleans_is_boolean(): - # https://github.com/pandas-dev/pandas/issues/46313 - df = pd.DataFrame( - {"int_cat": [1, 2, 3], "bool_cat": [True, False, False]}, dtype="category" - ) - value = df["bool_cat"].cat.categories.dtype - expected = np.dtype(np.bool_) - not_expected = np.dtype(np.object_) - assert value is expected - assert value is not not_expected From b9923cdc218a1cd38763f9268e2d6babea75eae5 Mon Sep 17 00:00:00 2001 From: rxd330 Date: Fri, 18 Mar 2022 19:35:59 +0000 Subject: [PATCH 3/4] TST:test added for GH46313 --- pandas/tests/dtypes/test_dtypes.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pandas/tests/dtypes/test_dtypes.py b/pandas/tests/dtypes/test_dtypes.py index f077317e7ebbe..580d136505210 100644 --- a/pandas/tests/dtypes/test_dtypes.py +++ b/pandas/tests/dtypes/test_dtypes.py @@ -1107,3 +1107,15 @@ def test_compare_complex_dtypes(): with pytest.raises(TypeError, match=msg): df.lt(df.astype(object)) + + +def test_categorical_of_booleans_is_boolean(): + # https://github.com/pandas-dev/pandas/issues/46313 + df = pd.DataFrame( + {"int_cat": [1, 2, 3], "bool_cat": [True, False, False]}, dtype="category" + ) + value = df["bool_cat"].cat.categories.dtype + expected = np.dtype(np.bool_) + not_expected = np.dtype(np.object_) + assert value is expected + assert value is not not_expected From 9fac1115cd11fe31f8c8c84793c49b65c8066216 Mon Sep 17 00:00:00 2001 From: rxd330 Date: Sun, 20 Mar 2022 15:07:27 +0000 Subject: [PATCH 4/4] file reformated --- pandas/tests/dtypes/test_dtypes.py | 12 ------------ pandas/tests/series/accessors/test_cat_accessor.py | 9 +++++++++ 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/pandas/tests/dtypes/test_dtypes.py b/pandas/tests/dtypes/test_dtypes.py index 580d136505210..f077317e7ebbe 100644 --- a/pandas/tests/dtypes/test_dtypes.py +++ b/pandas/tests/dtypes/test_dtypes.py @@ -1107,15 +1107,3 @@ def test_compare_complex_dtypes(): with pytest.raises(TypeError, match=msg): df.lt(df.astype(object)) - - -def test_categorical_of_booleans_is_boolean(): - # https://github.com/pandas-dev/pandas/issues/46313 - df = pd.DataFrame( - {"int_cat": [1, 2, 3], "bool_cat": [True, False, False]}, dtype="category" - ) - value = df["bool_cat"].cat.categories.dtype - expected = np.dtype(np.bool_) - not_expected = np.dtype(np.object_) - assert value is expected - assert value is not not_expected diff --git a/pandas/tests/series/accessors/test_cat_accessor.py b/pandas/tests/series/accessors/test_cat_accessor.py index 1a038839a67c9..53158482fde46 100644 --- a/pandas/tests/series/accessors/test_cat_accessor.py +++ b/pandas/tests/series/accessors/test_cat_accessor.py @@ -282,3 +282,12 @@ def test_set_categories_setitem(self): # values should not be coerced to NaN assert list(df["Sex"]) == ["female", "male", "male"] assert list(df["Survived"]) == ["Yes", "No", "Yes"] + + def test_categorical_of_booleans_is_boolean(self): + # https://github.com/pandas-dev/pandas/issues/46313 + df = DataFrame( + {"int_cat": [1, 2, 3], "bool_cat": [True, False, False]}, dtype="category" + ) + value = df["bool_cat"].cat.categories.dtype + expected = np.dtype(np.bool_) + assert value is expected