Skip to content

Conversation

@phofl
Copy link
Member

@phofl phofl commented Jan 7, 2022

This worked for me locally

@pep8speaks
Copy link

pep8speaks commented Jan 7, 2022

Hello @phofl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-07 13:25:05 UTC

@jreback jreback added this to the 1.4 milestone Jan 8, 2022
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Jan 8, 2022
@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

@phofl i think i merged some things, can you merge master and ping when ready

# Conflicts:
#	pandas/core/arrays/masked.py
#	pandas/core/dtypes/cast.py
#	pandas/core/indexes/base.py
#	pandas/core/reshape/reshape.py
@jreback jreback merged commit d603d43 into pandas-dev:master Jan 10, 2022
@lumberbot-app

This comment has been minimized.

@jreback
Copy link
Contributor

jreback commented Jan 10, 2022

thanks @phofl hopefully this should backport

@jreback
Copy link
Contributor

jreback commented Jan 10, 2022

hmm i guess not, if you can push a manula backport @phofl

@phofl
Copy link
Member Author

phofl commented Jan 10, 2022

Will try to setup a pr in the evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants