Skip to content

Conversation

@isVoid
Copy link
Contributor

@isVoid isVoid commented Dec 15, 2021

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention that this happens because we convert the level to a regular Index instead of a MultiIndex

@isVoid
Copy link
Contributor Author

isVoid commented Dec 15, 2021

I was hesitant to write "internally MultiIndex is implemented by codes but regular index doesn't", concerning that reveals too much implementation details in the docstring. Let me know if it fits in.

@jreback
Copy link
Contributor

jreback commented Dec 20, 2021

can you add an example which illustrates this as well.

@isVoid
Copy link
Contributor Author

isVoid commented Dec 29, 2021

Example added. @jreback

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment. ping when ready

@jreback jreback added this to the 1.4 milestone Jan 5, 2022
@jreback jreback merged commit edb9d62 into pandas-dev:master Jan 5, 2022
@jreback
Copy link
Contributor

jreback commented Jan 5, 2022

thanks @isVoid

@jreback
Copy link
Contributor

jreback commented Jan 5, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 5, 2022

Something went wrong ... Please have a look at my logs.

lithomas1 pushed a commit that referenced this pull request Jan 6, 2022
…cit type casting if level contains null. (#45210)

Co-authored-by: Michael Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: MultiIndex constructed with nulls inconsistent with dtypes and get_level_values

3 participants