Skip to content

[ArrayManager] TST: run all tests with separate not slow / slow build #40495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2021
Merged

[ArrayManager] TST: run all tests with separate not slow / slow build #40495

merged 6 commits into from
Mar 20, 2021

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Mar 18, 2021 •
edited
Loading

xref #39146

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Internals Related to non-user accessible pandas implementation labels Mar 18, 2021
@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Mar 18, 2021

@jreback @jbrockmendel as discussed, this splits the current actions build with ArrayManager in two and runs the full test suite with slow / not slow markers.

@jbrockmendel
Copy link
Member

jbrockmendel commented Mar 18, 2021

nice. any estimate how this affects CI runtime?

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Mar 18, 2021

any estimate how this affects CI runtime?

Note that with this PR, not much changes (we were already running almost all tests in this build). It is #40496 that is adding tests to all other builds

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Mar 18, 2021

And to answer your actual question: this added one build (for the slow tests) that takes 25m.

@jreback jreback added this to the 1.3 milestone Mar 20, 2021
@jreback jreback merged commit 3e6bc0c into pandas-dev:master Mar 20, 2021
@jreback
Copy link
Contributor

jreback commented Mar 20, 2021

thanks @jorisvandenbossche very nice

@jorisvandenbossche jorisvandenbossche deleted the am-tests branch March 20, 2021 19:55
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jorisvandenbossche @JulianWgs
[ArrayManager] TST: run all tests with separate not slow / slow build (…
d4e9a87 
…pandas-dev#40495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Internals Related to non-user accessible pandas implementation Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@jorisvandenbossche @jbrockmendel @jreback